[#33598] - [4][Banners] Remove zip file when downloading tracks
- Fixed in Code Base
- 7 May 2021
- Medium
- Build: 4.0-dev
- # 33598
- Diff
- PhilETaylor:banners/deletezipfile
- Pending continuous-integration/drone/pr Build is running Details
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
- Success Download Prebuilt packages are available for download. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Trying to find the most useless PR of the decade on a feature that no one ever uses... I thought FTP Layer was it, but this might well take the crown.
When you export Banner Tracks to a CSV file, Joomla first (by default) creates a zip file in the TMP folder. It then serves you the Zip content as a download but leaves the Zip file in the TMP folder with a semi unique file name like
banners_tracks_6094508e34f0b.zip
This file is left in the TMP folder forever and not cleaned up.
Testing Instructions
Grab a coffee.
Create a banner client
Create a banner - ensure track impressions/clicks is enabled
Edit the banner options - ensure track impressions/clicks is enabled
Create a Site Module for banners, put it in a position in your template, load your frontend to "make tracks"
revisit the admin, Components -> Banners -> Tracks
Click Export
Leave Compressed = YES
Click Export
Note you are served a ZIP file to download
CHECK TMP FOLDER see file like banners_tracks_6094508e34f0b.zip left in the TMP folder
delete that file
APPLY PR
Click Export
Leave Compressed = YES
Click Export
Note you are served a ZIP file to download
CHECK TMP FOLDER see no left over ZIP file.
Actual result BEFORE applying this Pull Request
Zip file like banners_tracks_6094508e34f0b.zip left in the TMP folder
Expected result AFTER applying this Pull Request
Zip file is cleaned up and not left on the server.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Labels |
Added:
?
|
||
| Category | Administration com_banners | ⇒ | Administration com_banners Front End Templates (site) |
| Category | Administration com_banners Front End Templates (site) | ⇒ | Administration com_banners |
on a feature that no one ever uses
if ("no one" === "PhilETaylor")
{
return true;
}
else
{
return false;
}
What can I say. I know how to test things and moan a lot.
I have tested this item
Guess you are the only one found this issue and fix it :D.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33598.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33598.
| Labels |
Added:
?
|
||
I've restored the previous test results in the issue tracker since the commit which invalidated them was just a change in a code comment.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-07 17:10:39 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
Removed: ? |
||
Thank you!
I have tested this item✅ successfully on 693c770
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33598.