NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 May 2021

The login module is positioned with a fixed margin-top of 9rem. This prevents the module being positioned in the centre at certain screen sizes and can result in parts of the login being "below the fold".

Simply changing to margin:auto resolves that.

To test don't forget to npm i

Before

before

After

after

avatar brianteeman brianteeman - open - 6 May 2021
avatar brianteeman brianteeman - change - 6 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2021
Category Administration Templates (admin) NPM Change
avatar sandramay0905 sandramay0905 - test_item - 6 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 6 May 2021

I have tested this item successfully on 757586a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33570.

avatar HLeithner
HLeithner - comment - 6 May 2021

@brianteeman is this PR still valid?

avatar YatharthVyas YatharthVyas - test_item - 6 May 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 6 May 2021

I have tested this item successfully on 757586a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33570.

avatar ChristineWk ChristineWk - test_item - 6 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 6 May 2021

I have tested this item successfully on 757586a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33570.

avatar brianteeman
brianteeman - comment - 6 May 2021

Closed as this is resolved in the repaint (hence the conflicts)

avatar brianteeman brianteeman - change - 6 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-06 09:50:55
Closed_By brianteeman
Labels Added: NPM Resource Changed ?
avatar brianteeman brianteeman - close - 6 May 2021

Add a Comment

Login with GitHub to post a comment