Feeling Lucky
?
[#33569] - [4.0] (Issue Resolved) Backend - Add padding to module card headers
- Closed
- 6 May 2021
- Medium
- Build: 4.0-dev
- # 33569
- Diff
- YatharthVyas:fix-atum-cog
User tests: Successful: Unsuccessful:
Pull Request for Issue #33566
Summary of Changes
This PR adds padding to the header to ensure that the cog icon which has been styled with position: absolute does not overlay on top of the header text. If a custom header_class param is set then this will not override its padding.
Testing Instructions
- Visit Backend
- Refer to the gif below: Shrink your screen width to reach a breakpoint where the Module Header text is long enough to cover the full width of the card OR you can use inspect element to rewrite the header text such that it covers full width or the card.
Before the PR, the cog would overlay on top of the text because of its absolute position and higher z-index.
After the PR, the padding creates a gap that separates the cog icon from the text by wrapping the text to the next line.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
YatharthVyas
- comment
- 6 May 2021
Closing this PR as the issue is fixed with the Admin repaint update
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-06 10:08:22 |
| Closed_By | ⇒ | YatharthVyas | |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item✅ successfully on 0ac8696
@YatharthVyas thanks for solving the issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33569.