? ? Pending

User tests: Successful: Unsuccessful:

avatar GeraintEdwards
GeraintEdwards
4 May 2021

… value - fixes issue #33538

Pull Request for Issue # .

Summary of Changes

Remove onchange function call from calendar.js - this is no longer needed since we now have a disptachEvent for the change event

Testing Instructions

edit the file administrator/components/com_content/forms/article.xml and find the publish_up field at line 129 and add the attrribute

onchange="alert(0);"

to this field and then edit an article and change the publish_up field (using the date picker)

Actual result BEFORE applying this Pull Request

you will get the alert(0) being called twice

Expected result AFTER applying this Pull Request

alert(0) is called once

Documentation Changes Required

avatar GeraintEdwards GeraintEdwards - open - 4 May 2021
avatar GeraintEdwards GeraintEdwards - change - 4 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2021
Category JavaScript
avatar RickR2H RickR2H - test_item - 4 May 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 4 May 2021

I have tested this item successfully on 7bc0667


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33540.

avatar Fedik Fedik - test_item - 8 May 2021 - Tested successfully
avatar Fedik
Fedik - comment - 8 May 2021

I have tested this item successfully on 7bc0667


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33540.

avatar Fedik
Fedik - comment - 8 May 2021

can you please make the same for joomla 4?

avatar richard67 richard67 - change - 8 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 8 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33540.

avatar GeraintEdwards
GeraintEdwards - comment - 10 May 2021

Please see #33731 for mirrored changes in Joomla 4

avatar HLeithner HLeithner - change - 15 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-15 10:07:34
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 15 May 2021
avatar HLeithner HLeithner - merge - 15 May 2021
avatar HLeithner
HLeithner - comment - 15 May 2021

thanks

Add a Comment

Login with GitHub to post a comment