? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
4 May 2021

Pull Request for Issue #33525.

Summary of Changes

Update Required Language files

Testing Instructions

You can add the Admin Module - Login Form to your admin dashboards - this makes literally no sense!

Also it states you cannot unpublish it - this is a lie, you can, you can click the cog and click unpublish ;)

Please enable two factor Authentication

Actual result BEFORE applying this Pull Request

mod_login_before

mod_login__before

Expected result AFTER applying this Pull Request

mod_login_after

mod_login__after

Documentation Changes Required

None

avatar rjharishabh rjharishabh - open - 4 May 2021
avatar rjharishabh rjharishabh - change - 4 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2021
Category Administration Language & Strings Modules
avatar brianteeman
brianteeman - comment - 4 May 2021

Not every module is designed to work everywhere. Just as it would be crazy if you put the popular articles module in the toolbar position. The only thing that does need to be changed is the language string. Changing the text from "it can't be" to "it should not be"

avatar rjharishabh
rjharishabh - comment - 4 May 2021

It can be unpublished from Admin dashboard

avatar brianteeman
brianteeman - comment - 4 May 2021

it can be but you should not

avatar rjharishabh rjharishabh - change - 4 May 2021
Labels Added: ? ?
avatar rjharishabh
rjharishabh - comment - 4 May 2021

No need of this PR

avatar rjharishabh rjharishabh - change - 4 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-04 08:00:09
Closed_By rjharishabh
avatar rjharishabh rjharishabh - close - 4 May 2021

Add a Comment

Login with GitHub to post a comment