? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
4 May 2021

Pull Request for Issue #33526

Summary of Changes

Adds float-end class to span.badge and removes justify-content-between class from it's parent <li> resulting in the badges being right aligned

Testing Instructions

  1. From the Admin Panel, add the Statistics Module to your frontend and publish it.
  2. Visit Frontend and check that the badges are aligned to the right end after the patch is applied

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 4 May 2021
avatar YatharthVyas YatharthVyas - change - 4 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2021
Category Modules Front End
avatar sandramay0905 sandramay0905 - test_item - 4 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 4 May 2021

I have tested this item successfully on 6d81c00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33533.

avatar brianteeman
brianteeman - comment - 4 May 2021

Please test/try this when the module is correctly set to be 50% width of the screen. (your install isn't quite up to date so go to the module and set the bootstrap width to 12)

avatar brianteeman
brianteeman - comment - 4 May 2021

sorry mea culpa. Commenting on so many admin modules I missed this was for the frontend

avatar rjharishabh rjharishabh - test_item - 4 May 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 4 May 2021

I have tested this item successfully on 6d81c00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33533.

avatar alikon alikon - change - 4 May 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 4 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33533.

avatar chmst chmst - change - 4 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-04 09:39:09
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 4 May 2021
avatar chmst chmst - merge - 4 May 2021
avatar chmst
chmst - comment - 4 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment