NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 May 2021

Kills the deprecated (and useless) cellpadding and cellspacing.

There should be no visual impact on the calendar

Testing requires npm i

avatar brianteeman brianteeman - open - 3 May 2021
avatar brianteeman brianteeman - change - 3 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category JavaScript Repository NPM Change
avatar Shubham-com Shubham-com - test_item - 3 May 2021 - Tested successfully
avatar Shubham-com
Shubham-com - comment - 3 May 2021

I have tested this item successfully on d296496


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33505.

avatar Quy Quy - test_item - 3 May 2021 - Tested successfully
avatar Quy
Quy - comment - 3 May 2021

I have tested this item successfully on d296496


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33505.

avatar Quy Quy - change - 3 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 3 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33505.

avatar richard67
richard67 - comment - 4 May 2021

@brianteeman Could you update the branch of this PR to latest 4.0-dev so it gets the change from #33507 ? Without that, appveyor fails, and so merging of this PR requires more privileges than I and most other maintainers have. I will restore test results after that, so no need for re-test.

avatar brianteeman
brianteeman - comment - 4 May 2021

@richard67 I wont be able to do it today as I am in the studio filming but you can do this for me

avatar richard67
richard67 - comment - 4 May 2021

@brianteeman Ok, will do later if no forced merge before. I wish you success with filming.

avatar richard67 richard67 - change - 4 May 2021
Labels Added: ?
avatar richard67 richard67 - change - 4 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-04 17:56:22
Closed_By richard67
Labels Added: NPM Resource Changed ?
Removed: ?
avatar richard67 richard67 - close - 4 May 2021
avatar richard67 richard67 - merge - 4 May 2021
avatar richard67
richard67 - comment - 4 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 4 May 2021

thanks

Add a Comment

Login with GitHub to post a comment