Feeling Lucky
?
?
[#33470] - [4.0] toggle editor icon
- Fixed in Code Base
- 1 May 2021
- Medium
- Build: 4.0-dev
- # 33470
- Diff
- brianteeman:toggle
User tests: Successful: Unsuccessful:
Please be gentle javascript is not my thing
Pull Request for Issue ##33465
Summary of Changes
change the icon when the toggle editor button is toggled
Testing Instructions
- apply pr
- npm i
- new article and click on button
Actual result BEFORE applying this Pull Request
button toggles the editor but does not visually change
Expected result AFTER applying this Pull Request
button toggles the editor and the icon changes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
ChristineWk
- comment
- 1 May 2021
see Note above:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33470.
rjharishabh
- comment
- 1 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33470.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 1 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33470.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-01 21:53:55 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 1 May 2021
Thanks!
brianteeman
- comment
- 1 May 2021
What? I wrote three lines of javascript and it didnt need any corrections. Wow.
thanks for testing and merging
richard67
- comment
- 1 May 2021
What? I wrote three lines of javascript and it didnt need any corrections. Wow.
The error would have come with the 4th line ;-)
I have tested this item✅ successfully on 7fcf080
In principle, PR successful.
Note: when I scroll back and forth, it sometimes appears:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33470.