? ? Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
1 May 2021

Summary of Changes

A small fix that removes the <hr> tag in the installation plugin layouts.

I noticed that in other places in Joomla, the <hr> tag is placed only immediately before the button, and not BEFORE and AFTER. For example, the Joomla update page:

Screenshot_5

Go to System - Install (Extension). Look at the tabs to install the extension. From the screenshots it is clear what changes the PR.

BEFORE / AFTER

Screenshot_1

Screenshot_2

avatar Kostelano Kostelano - open - 1 May 2021
avatar Kostelano Kostelano - change - 1 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2021
Category Front End Plugins
avatar ChristineWk ChristineWk - test_item - 1 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 1 May 2021

I have tested this item successfully on d95b75e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33462.

avatar sandramay0905 sandramay0905 - test_item - 1 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 1 May 2021

I have tested this item successfully on d95b75e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33462.

avatar richard67 richard67 - change - 1 May 2021
Title
[4.0] Removed <hr> tag in installation plugins
[4.0] Removed tag in installation plugins
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 1 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33462.

avatar richard67
richard67 - comment - 1 May 2021

Drone failure is not related to this PR.

avatar richard67
richard67 - comment - 1 May 2021

Restarted drone. All fine now.

avatar chmst chmst - change - 1 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-01 17:18:36
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 1 May 2021
avatar chmst chmst - merge - 1 May 2021
avatar chmst
chmst - comment - 1 May 2021

Thanks

avatar Quy
Quy - comment - 1 May 2021

Let's remove the <hr> before the button too.

Add a Comment

Login with GitHub to post a comment