[#33457] - [4] Add intl extension check to system info, and while there clean up deprecations/types/[]
- Fixed in Code Base
- 1 May 2021
- Medium
- Build: 4.0-dev
- # 33457
- Diff
- PhilETaylor:sysinfo
User tests: Successful: Unsuccessful:
Summary of Changes
As a result of #33451 and #33454 I noticed ICONV was checked but not INTL - as both are needed for File::makeSafe it makes sense to have both listed in the System Information for ease of reference.
While in this code, took the opportunity to remove deprecated getDBO method calls and add param types and return types.
Testing Instructions
Load System Information in Joomla Admin - if it loads, great. Check PHP tab and see your status of INTL (checks for presence of the function transliterator_transliterate which is the one Joomla uses in File::makeSafe
Try JSON and TXT download.
Actual result BEFORE applying this Pull Request
Works - but intl extension not in the list
Expected result AFTER applying this Pull Request
Still works - but calls one less deprecated function and code is slightly more modern and less warnings in phpStorm.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings |
| Labels |
Added:
?
?
|
||
If this PR will be merged, the same check should also be added to the Joomla Update Component's Pre-Update Checks. This will have to be done in the 3.10-dev branch so it can be checked before updating from 3.10 to 4. I could do that if necessary.
@PhilETaylor Do I understand right that the INTL extension is only needed in J4, not in J3? Or is that wrong and it should also be checked in J3? If my understanding is right, then the future PR for the pre-update check should show the check for INTL only if the version to be updated to is J4, like we have it already with the database compatibility check for MS SQL Server.
Update: I just see the INTL is only needed for transliteration, so it makes sense to add it to the system info with this PR here, but it is not a required setting to be checked by the Pre-Update Check. What could make sense is to add it to the recommended settings in the Pre-Update Checker.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33457.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33457.
Drone failure is not related to this PR just by the way.
Restarted drone. All fine now.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-01 18:41:44 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!
I have tested this item✅ successfully on 68d52d8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33457.