Sorry this is not correct as it results in $pageclass.$hasclass

I have tested this item ? unsuccessfully on 30e1e16

ok try again now - improved it.

honestly as long as there is a space between classes who cares if its one or two

I care enough to fix it. It makes the output look amateurish. We can do better.

better to be maintainable and understandable

And on that note Im going to bed. There is nothing non-maintainable or non-understandable about this PR or trying to do better...

For example - this sucks as output!

</div>
	<div class="controls">
		<input
	type="email"
	inputmode="email"
	name="jform[email]"
	 class="form-control validate-email required"	id="jform_email"
	value=""
	 size="30"     autocomplete="email"    required  >			</div>
</div>

Here is one way and then implode.

Imploding on $attributes actually GIVES double empty spaces :) unless you first filter out the blank array entries.

@richard67 added the Updates Requested label 6 hours ago

This PR is ready for testing, no further updates are needed, it produces maintainable and understandable output.

The commentary was on other improvements around output that can be made to the email fields (Which is on my todo list)

@PhilETaylor I don't think that this is right: $hasClass .= 'has-sidebar-left';. I think the space which was there before was right.

Dont think - test :) you will see the final output code it correct. Line 117 correctly outputs the space that was removed from 84/89

Dont think - test :) you will see the final output code it correct. Line 117 correctly outputs the space that was removed from 84/89

No need to test if reading the code shows it's wrong. If in line 84 the variable has a value, let's say 'gaga', you append 'has-sidebar-left' to it when there is a module on the left sidebar, which results in 'gagahas-sidebar-left', and that's wrong.

And if there was no value in line 84 so it ends in 'has-sidebar-left', you append later in line 'has-sidebar-right' to it when there is a module on the right sidebar, and the ends in 'has-sidebar-lefthas-sidebar-right'. How shall line 117 clean that up? I don't see how it can do that.

added back one space - its so ugly having strings that start with a space like " this" - just makes code so ugly

just makes code so ugly

or makes it work

Thanks for your helpful insight once again - I wish I can be like you when I grow up.

Thanks @PhilETaylor .

I have tested this item ✅ successfully on acc7384

I have tested this item ✅ successfully on acc7384

RTC

Drone failure is not related to this PR, see issue #33477 .

I've updated the branch to latest 4.0-dev to get rid of the unrelated javascript-cs error in drone and restored the previous test results in the issue tracker.

Thanks!