[#33451] - [4] Folder creation - Feedback INTL and ICONV PHP Extensions not installed
- Closed
- 6 Mar 2022
- Medium
- Build: 4.0-dev
- # 33451
- Diff
- PhilETaylor:media/handleiconvmising
User tests: Successful: Unsuccessful:
Pull Request for Issue #33449 .
Summary of Changes
If you are on a server where ICONV AND INTL extensions are NOT installed and you try to create a folder in com_media with name ыыыыыыыы then it will fail, but tell you that it created the folder.
This PR handles that, and tells you the real reason.
Testing Instructions
On a server where ICONV AND INTL extensions are NOT installed and you try to create a folder in com_media with name ыыыыыыыы then it will fail, but tell you that it created the folder.
Apply PR
On a server where ICONV AND INTL extensions are NOT installed and you try to create a folder in com_media with name ыыыыыыыы then it will fail, but tell you that it failed to create the folder.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none.
Isolated code test proving this issue available here https://3v4l.org/BRcNa
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Title |
|
||||||
Do we need the same language constant in the frontend?
probably. Im only doing half jobs tonight :)
Frontend seems to use the backend lang constants.
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
I've restored @Kostelano 's test result in the issue tracker so it's properly counted again, since the commit which invalidated the count was just a change in the language string for better English.
@PhilETaylor There is already a language string with (almost) the same text as the one added by you in this PR here. It has added by you with your PR #33454 here:
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/language/en-GB/com_media.ini#L72
Beside that it has been added ad the wrong place regarding alphabetical order, we should use one common string for the same message from the other PR and this one here.
I leave it up to you which one you use, but I'd prefer to use the one added by this PR here, remove the other one and change to the new sting at the following 2 places:
https://github.com/PhilETaylor/joomla-cms/blob/4.0-dev/plugins/filesystem/local/src/Adapter/LocalAdapter.php#L552
Another problem I have: Since PR #33454 has been merged, I can't reproduce issue #33449 anymore. When attempting to create a new folder with only cyrillic characters and intl not available, I get the new message introduced with PR #33454 , even if that PR says it was for copying only:
But from code review I'd say this PR here is ok for me if the issue with the language strings I've mentioned above is solved.
| Labels |
Added:
Language Change
?
?
Removed: ? ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-06 21:17:06 |
| Closed_By | ⇒ | PhilETaylor |
I have tested this item✅ successfully on 1fd487c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33451.