?
avatar Kostelano
Kostelano
30 Apr 2021

Steps to reproduce the issue

Continuing theme #33378, I inform you about another place where there is no LEGEND. At the moment, I no longer find such places.

@YatharthVyas, I am reaching out to you because you have already made corrections in this regard and you might want to add another modic one too :). Thanks anyway for your participation.

So, in the control panel go to private messages - My settings.

Screenshot_1

avatar Kostelano Kostelano - open - 30 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Apr 2021
avatar YatharthVyas
YatharthVyas - comment - 30 Apr 2021

@Kostelano Thanks for notifying me!

I hope this is the correct legend text:

COM_MESSAGES_CONFIGURATION="Messages: Options"

image

The name of this view is 'config' which matches with the name COM_MESSAGES_CONFIGURATION. I also ran a file lookup and this language Text wasn't used anywhere so I figured it must be placed here.

avatar Kostelano
Kostelano - comment - 30 Apr 2021

Thank you. It might be better to use a new constant that won't bind to the component's settings header. Something like: My Settings or Basic Settings .

avatar YatharthVyas
YatharthVyas - comment - 30 Apr 2021

Thank you. It might be better to use a new constant that won't bind to the component's settings header. Something like: My Settings or Basic Settings .

I hope I understood it correctly, The language constant bound to the header is:

COM_MESSAGES_TOOLBAR_MY_SETTINGS="My Settings"

and the new one which I've used is:

COM_MESSAGES_CONFIGURATION="Messages: Options"

This, COM_MESSAGES_CONFIGURATION is not used anywhere else so do you still suggest I make a new constant? Or should I rename the above to:
COM_MESSAGES_CONFIGURATION:"My Settings"
to ensure it is not bound to the header but matches it's text

avatar Kostelano
Kostelano - comment - 30 Apr 2021

Specifically, the colon in the legend confuses me. But this is just my humble opinion :). Therefore, I would prefer to leave "My settings".

avatar Kostelano Kostelano - change - 30 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-30 19:34:00
Closed_By Kostelano
avatar Kostelano Kostelano - close - 30 Apr 2021
avatar Kostelano
Kostelano - comment - 30 Apr 2021

PR #33442

Add a Comment

Login with GitHub to post a comment