No Code Attached Yet
avatar brianteeman
brianteeman
29 Apr 2021

Steps to reproduce the issue

J4 has two new plugins - behaviour tags and behaviour versions that have a description of
Allows content items to be tagged.
Allows content items to be versioned.

Expected result

1. From the description I expect that disabling the plugins will remove the ability to version or tag a content item but that it still is possible to version or tag another item such as a contact.
2. If I can't version an item then I would expect not to see a versions button in the toolbar or a version note field
3. If I did add a version note and then save I would expect to get some sort of message instead of the note being silently discarded
4. If I can't tag an item then I would expect not to see the tag field where I can select an existing tag
5. If I can tag an item and then save I would expect to get some sort of message instead of the tag being silently discarded

Actual result

1. The plugins apply everywhere not just content
2. version button displayed and active
3. version note field displayed but cannot be updated
4. tags field is displayed where it appears that I can select a tag or even create a new one

Why?

Why do we even have these plugins
If we do have these plugins I would expect them to be applied per component and configured in the integration tab of the component
At an absolute minimum the description of the plugin should be updated to show that they apply to all items not just content items

Updated after #33420

avatar brianteeman brianteeman - open - 29 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 30 Apr 2021

Why do we even have these plugins

The plugins only provide themselves the the onTable* hooks for Tables that implement the TaggableTableInterface or VersionableTableInterface

In order for these features to work 1) The plugins must be published 2) The Joomla Table PHP Classes, for the component, need to implement the TaggableTableInterface or VersionableTableInterface interfaces.

The only tables that implement these interfaces, and therefore have these features are:

Component VersionableTableInterface TaggableTableInterface
Content Yes Yes
Banners Yes No
Banner Clients Yes No
Contacts Yes Yes
Newsfeeds Yes Yes
Tags Yes No
User Notes Yes No
Categories Yes Yes
All other extensions No No

As you can see this is not the full list of Joomla components, I guess its a half implemented set of features.

The use of the word "content" in the phrase "Allows content items to be tagged" is applied to mean "The royal content" and not as in "Content = Articles" in the same way as content in "Content Management System" doesn't mean "Article Management System" but a management system to control all your content, be that menus, articles, media etc.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

As you can see this is not the full list of Joomla components, I guess its a half implemented set of features.

Well it wouldnt make sense to tag a tag ;)

None of this explains why its a plugin or explains the broken behaviour described

The use of the word "content" in the phrase "Allows content items to be tagged" is applied to mean "The royal content" and not as in "Content = Articles"

Easy enough for us who speak english. I wonder how many translated sites will maintain that distinction

avatar PhilETaylor
PhilETaylor - comment - 30 Apr 2021

None of this explains why its a plugin or explains the broken behaviour described

I was not involved in its creation, but it seems to be a plugin so it can be easily disabled. But as you rightly state, this only disables the onTable* hooks and not the actual Form fields and buttons in an extension's views - yet.

Broken = Half implemented.

Easy enough for us who speak english. I wonder how many translated sites will maintain that distinction

We have the same things of "The royal content" in the left menu - where "Content" is the top level and "Articles" and other things are below it

Screenshot 2021-04-30 at 08 46 48

avatar brianteeman
brianteeman - comment - 30 Apr 2021

At an absolute minimum the description of the plugin should be updated to show that they apply to all items not just content items

#33420 for that part

avatar brianteeman brianteeman - change - 30 Apr 2021
The description was changed
avatar brianteeman brianteeman - edited - 30 Apr 2021
avatar brianteeman brianteeman - change - 30 Apr 2021
The description was changed
avatar brianteeman brianteeman - edited - 30 Apr 2021
avatar brianteeman brianteeman - change - 30 Apr 2021
The description was changed
avatar brianteeman brianteeman - edited - 30 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 30 Apr 2021

as a test of the concept, please test #33422

avatar brianteeman brianteeman - change - 1 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-01 23:05:35
Closed_By brianteeman
Labels Added: No Code Attached Yet
Removed: ?
avatar brianteeman brianteeman - close - 1 Feb 2022

Add a Comment

Login with GitHub to post a comment