[#33417] - [4.0] icon for non featured
- Fixed in Code Base
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33417
- Diff
- brianteeman:circle
User tests: Successful: Unsuccessful:
The icon used for featured/default is a yellow five pointed star
The icon used for non-featured/nondefault is a mono five pointed star
This fails basic accessibility as it is using color alone as an indicator
This PR changes the nonfeatured/nondefaault icon to a circle (this was already used in com_menus for non-home/non-default
To test apply pr and then
- check the icon used for featured in com_content, com_contact
- check the icon used for default in template styles
- check the icon used for default in com_workflows
Pull Request for Issue #33296
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Does this solve all aspects of the issue, or is there something remaining?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33417.
I have tested this item
As @Quy comment contacts show still the mono five pointed star.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33417.
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Administration com_contact com_content Libraries |
Should be correct now.
@brianteeman Does this PR here solve issue #33296 completely? To me it seems it doesn't, because the list of issues in the issue's description seems to mention more than the description of this PR. And you had not closed the issue after making this PR, so I thought that could be by purpose. Was it right that @alikon closed the issue, or not?
I have tested this item
tested icon used for featured in com_content, com_contact
tested icon used for default in template styles
tested icon used for default in com_workflows
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33417.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33417.
@richard67 you are correct. I should have written partial pull request
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33417.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 11:09:46 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
thx
Contacts is still the mono five pointed star.