? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
28 Apr 2021

Summary of Changes

Empty state for when no extensions are discovered.

MOST OF THE TIME you will expect to see the Empty State. Its rare to see extensions needing discovering. This is the opposite of most components in Joomla admin.

Testing Instructions

Apply PR

Load System -> discover,

See Empty State

click discover... or the button in the middle

Note new message. Nothing found.

upload a plugin/extension manually into its right place using FTP (or copy and paste on your local machine)

Load System -> discover, click discover...

See you see the old screen where you can install the extension

Actual result BEFORE applying this Pull Request

Screenshot 2021-04-28 at 23 46 50

Expected result AFTER applying this Pull Request

Screenshot 2021-04-28 at 23 43 50

When you click either discover button you get a new message, or redirected to the list of discovered extensions to install (as normal)

Screenshot 2021-04-28 at 23 43 56

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 28 Apr 2021
avatar PhilETaylor PhilETaylor - change - 28 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2021
Category Administration com_installer Language & Strings Layout
avatar PhilETaylor PhilETaylor - change - 28 Apr 2021
Title
Empty State for System-> Discover
[4] Empty State for System-> Discover
avatar PhilETaylor PhilETaylor - edited - 28 Apr 2021
avatar PhilETaylor PhilETaylor - change - 28 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 28 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 28 Apr 2021

And yes I hate the title and sentences too! - please suggestion new ones if you dont like them too. I'll not be offended.

avatar Quy Quy - change - 28 Apr 2021
Labels Added: ? ?
44c05e8 29 Apr 2021 avatar Quy oops
avatar Quy Quy - test_item - 29 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 29 Apr 2021

I have tested this item successfully on 68479a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33400.

avatar drmenzelit drmenzelit - test_item - 3 May 2021 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 3 May 2021

I have tested this item successfully on 68479a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33400.

avatar PhilETaylor
PhilETaylor - comment - 3 May 2021

This has conflicts (because com_installer has multiple empty states, and thus has language string conflicts) and cannot be merged just yet - I'll fix it once enough coffee has been injected into my veins.

avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category Administration com_installer Language & Strings Layout Unit Tests Repository Administration com_admin SQL Postgresql com_banners
avatar PhilETaylor PhilETaylor - change - 3 May 2021
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category Administration Unit Tests Repository com_admin SQL Postgresql com_banners Administration com_installer Language & Strings Layout
avatar PhilETaylor
PhilETaylor - comment - 3 May 2021

Conflicts resolved, merged in from 4.0-dev and ready for testing again. Thanks.

avatar PhilETaylor
PhilETaylor - comment - 7 May 2021

Hey @wilsonge If you are thinking of cutting another Joomla 4 beta very shortly can we quickly get this one and the other one I'll ping you merged, these are the last 2 Empty States and without them the feature is not yet fully implemented :-) Thanks.

avatar alikon
alikon - comment - 7 May 2021

missed from my radar ... due to the storm ?

avatar alikon alikon - test_item - 7 May 2021 - Tested successfully
avatar alikon
alikon - comment - 7 May 2021

I have tested this item successfully on 2b9078b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33400.

avatar alikon
alikon - comment - 7 May 2021

fields and field groups are in your radar @PhilETaylor ??

avatar PhilETaylor
PhilETaylor - comment - 7 May 2021

fields and field groups are in your radar @PhilETaylor ??

They are hard, due to the additional context and dropdown needed to make it make sense as an empty state

avatar PhilETaylor
PhilETaylor - comment - 7 May 2021

... due to the storm

We had the french try to invade our island yesterday.. such fun...

avatar richard67 richard67 - test_item - 7 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 7 May 2021

I have tested this item successfully on 2b9078b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33400.

avatar richard67 richard67 - edited - 7 May 2021
avatar richard67 richard67 - change - 7 May 2021
The description was changed
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33400.

avatar Quy Quy - close - 7 May 2021
avatar Quy Quy - merge - 7 May 2021
avatar Quy Quy - change - 7 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-07 14:05:31
Closed_By Quy
Labels Added: ? ?
Removed: ?
avatar Quy
Quy - comment - 7 May 2021

Thanks you!!!

Add a Comment

Login with GitHub to post a comment