[#33399] - [4] Allow banner creation if there are not categories
- Fixed in Code Base
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33399
- Diff
- PhilETaylor:allowbannercreationwithnocategories
User tests: Successful: Unsuccessful:
Summary of Changes
Allow banner creation if there are no banner categories.
Testing Instructions
Delete all your banner categories.
Note you cannot create any banners as the NEW toolbar button doesn't show
Actual result BEFORE applying this Pull Request
Note you cannot create any banners as the NEW toolbar button doesn't show
Expected result AFTER applying this Pull Request
You can click NEW to create a new Banner, and a new Uncategorised category is created on the fly when you save it.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Labels |
Added:
?
|
||
you were too quick for me ... I was multi tasking - now done.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33399.
The New button is fixed, but no Add your first banner button.
| Category | Administration com_banners | ⇒ | Administration com_banners com_installer |
| Category | Administration com_banners com_installer | ⇒ | Administration com_banners |
added that to this as well now
I have tested this item
Perfect! Thank you!!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33399.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33399.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33399.
A perfect fix would be store $canDo as a property of the class and use $this->canDo->get('core.create') instead of $user->authorise() but guess I'm asking too much :D
@PhilETaylor The next one with conflicts due to one of your other PR's, this time file administrator/components/com_banners/src/View/Banners/HtmlView.php. No need to hurry, just a remainder so it is addressed.
| Labels |
Added:
?
|
||
Done
I've restored previous test results in the tracker since the last commit after that was just a clean branch update and merge conflict resolution.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 10:47:19 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
Still not valid. Please use the suggested code #33380 (comment)