? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
28 Apr 2021

Pull Request for Issue #33368, alternative for #33372

Summary of Changes

This PR modifies code so that the field contexts filter will only be displayed if there are more than one option. Compare to #33372, it also remove the unnecessary mark up, so it is a bit better.

Testing Instructions

  1. Apply patch
  2. Go to Content -> Fields, Content -> Field Groups, make sure you still see contexts filter (contains Articles, Category).
  3. Go to Users -> Fields, Users -> Field Groups, make sure you do not see the filter anymore (before, the filter only contains on option Users ,so it is useless)
  4. Go to Users -> Fields, view source of the page, make sure you don't see the useless mark up which @Quy mentioned here #33372 (comment)
avatar joomdonation joomdonation - open - 28 Apr 2021
avatar joomdonation joomdonation - change - 28 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2021
Category Administration com_fields
avatar joomdonation joomdonation - change - 28 Apr 2021
The description was changed
avatar joomdonation joomdonation - edited - 28 Apr 2021
e111401 28 Apr 2021 avatar joomdonation CS
avatar joomdonation joomdonation - change - 28 Apr 2021
Labels Added: ?
avatar Quy Quy - test_item - 28 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 28 Apr 2021

I have tested this item successfully on e111401

Perfect! Thank you!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33387.

avatar rjharishabh rjharishabh - test_item - 28 Apr 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 28 Apr 2021

I have tested this item successfully on e111401

Superb! Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33387.

avatar alikon alikon - change - 28 Apr 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33387.

avatar drmenzelit drmenzelit - change - 28 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-28 10:15:40
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 28 Apr 2021
avatar drmenzelit drmenzelit - merge - 28 Apr 2021
avatar drmenzelit
drmenzelit - comment - 28 Apr 2021

Thanks!

Add a Comment

Login with GitHub to post a comment