[#33386] - [4.0] After deleting the last item, the empty state layout still has filter for trashed items activated
- Closed
- 1 May 2021
- Medium
- Build: staging
- # 33386
Steps to reproduce the issue
The following describes the issue for com_content, but we have it elsewhere, too.
It is like that on J3 since long time and so some kind of expected behaviour, i.e. not been introduced by the new empty states in J4.
But I think it's confusing and annoying the user, so we should take a chance to change that with J4.
- Have some articles so the articles list view in backend shows items.
- Trash all articles.
- Filter for trashed items.
- Select all trashed articles and empty trash.
Result: The empty state layout is shown. No filter tool bar is shown, but there is still the filter for trashed items active, as you will see in the next step- - Use the "New" button to create a new article.
- See that the status of the new article is "Trashed".
- Change it to "Published".
- Use the "Save & Close" button.
Result: The article list view is shown, The filter tool bar is visible, the filter for trashed items is set, and so the new article is not shown. That's confusing.
Alternatively you could skip step 6, then the article would be visible but have "Trashed" status, that's the same annoying.
Expected result
When the last item is deleted so that the empty state layout is show, all active filters are cleared.
Actual result
See above steps to reproduce.
System information (as much as possible)
Current 4.0-dev.
Additional comments
This issue has not been introduced by the empty states like I first thought because I didn't remember that this issue was confusing me long time ago in J3.
joomla-cms-bot
- | Labels |
Added:
?
|
||
This is exactly how it works currently - you are right. The Empty State code makes no changes to the filter state at all. So if your last filter selection was Trashed, then you would remain filtered with Trashed when you clicked the add new button and then Save & Close would take you back to a Trashed filtered view.
This is how its been for years.
This is no different to how it was before.
Im not saying this is how it should be, it can of course be improved, but this has not been broken or changed by Empty State Design.
I'm not sure if it was like that before.
I am off to bed, I will let you test and see that it has been this way forever :-)
There simply is no code in any of the new empty state changes to make any changes to the filter state, we just leave it alone.
nothing to do with empty state
This is no different to how it was before.
nothing to do with empty state
Confirmed. Was like that also on Beta 7, I've just tested.
@brianteeman Do you know if we have already an issue for that?
Closing for now. Sorry for the confusion.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-27 21:19:33 |
| Closed_By | ⇒ | richard67 |
@richard67 its this way by design and has always been this way. Watch this
I know meanwhile.
Re-opening the issue since I still think it is weird behaviour confusing the user, even if it is like that on J3 since ages.
I remember now it had confused me in past, and then I had forgotten about it, it seems.
Will change description and maybe title, too, so it's clear it was not introduced by the empty states.
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-04-27 21:19:33 | ⇒ | |
| Closed_By | richard67 | ⇒ |
I think when empty state is detected, filters should be reset/unset first before hiding the filter and any other unneeded buttons.
I think when empty state is detected, filters should be reset/unset first before hiding the filter and any other unneeded buttons.
Go for it.
I think when empty state is detected, filters should be reset/unset first before hiding the filter and any other unneeded buttons.
Go for it.
@PhilETaylor I don't really know how to do that. Would have to investigate it first. Maybe you can do it faster?
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-01 18:40:38 |
| Closed_By | ⇒ | richard67 |
Closing as having a pull request.
P.S. I am not 100% sure, but I think I remember it was working right before the empty state formerly called blank state layouts were introduced.