? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
27 Apr 2021

Pull Request for Issue #33368.

Summary of Changes

if (count($component->getContexts()) > 1)
{
	return $component->getContexts();
}

Testing Instructions

Admin > Users > Fields & Admin > Users > Field Groups

Actual result BEFORE applying this Pull Request

Users dropdown present

fields-before
field-groups-before

Expected result AFTER applying this Pull Request

Users dropdown absent

fields-after

field-groups-after

Documentation Changes Required

None

avatar rjharishabh rjharishabh - open - 27 Apr 2021
avatar rjharishabh rjharishabh - change - 27 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2021
Category Administration com_fields
avatar rjharishabh rjharishabh - change - 27 Apr 2021
Labels Added: ?
avatar sandramay0905 sandramay0905 - test_item - 27 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 27 Apr 2021

I have tested this item successfully on 5c05c1e

Fields- and Field Groups-dropdown in content and contact are untouched.

Thanks @rjharishabh


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33372.

avatar joomdonation joomdonation - test_item - 27 Apr 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 27 Apr 2021

I have tested this item successfully on 76f22f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33372.

avatar drmenzelit
drmenzelit - comment - 27 Apr 2021

@sandramay0905 can you please test again? There was a new commit after your test. Thanks

avatar Quy
Quy - comment - 27 Apr 2021

Please see #30532. Ideally, the markup should also be removed.

<div class="js-stools-field-selector">
	<div class="sr-only">
		<label id="context-lbl" for="context">
	context</label>
	</div>
	</div>
</div>
avatar rjharishabh
rjharishabh - comment - 28 Apr 2021

Please see #30532. Ideally, the markup should also be removed.

How I am unable to locate the file.

avatar Quy
Quy - comment - 28 Apr 2021

Apply your PR.
Go to Users > Fields
View page source.
Search for the markup:

<div class="js-stools-field-selector">
	<div class="sr-only">
		<label id="context-lbl" for="context">
	context</label>
	</div>
	</div>
</div>
avatar rjharishabh
rjharishabh - comment - 28 Apr 2021

@Quy
That I understand, I am unable to locate the file in the Joomla source code to remove the context.

avatar joomdonation
joomdonation - comment - 28 Apr 2021

@rjharishabh Not easy to explain, so I will make a PR to replace this one. Hope that's OK for you.

avatar sandramay0905 sandramay0905 - test_item - 28 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 28 Apr 2021

I have tested this item successfully on 76f22f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33372.

avatar joomdonation
joomdonation - comment - 28 Apr 2021

So I made alternative PR #33387 which address the issue which @Quy mentioned. Please test and if you agree that it is better, please close this PR.

avatar rjharishabh
rjharishabh - comment - 28 Apr 2021

Closing we have better PR #33387

avatar rjharishabh rjharishabh - close - 28 Apr 2021
avatar rjharishabh rjharishabh - change - 28 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-28 04:48:30
Closed_By rjharishabh

Add a Comment

Login with GitHub to post a comment