? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
27 Apr 2021

Pull Request for Issue #33368.

Summary of Changes

Just remove the context in joomla.searchtools.default

Testing Instructions

Admin > Users > Fields & Admin > Users > Field Groups

Actual result BEFORE applying this Pull Request

Users dropdown present

fields-before
field-groups-before

Expected result AFTER applying this Pull Request

fields-after

field-groups-after

Documentation Changes Required

None

avatar rjharishabh rjharishabh - open - 27 Apr 2021
avatar rjharishabh rjharishabh - change - 27 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2021
Category Administration com_fields
avatar brianteeman brianteeman - test_item - 27 Apr 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 27 Apr 2021

I have tested this item ? unsuccessfully on 57939b9

Obviously wrong as this removes contexts everywhere


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33371.

avatar rjharishabh rjharishabh - change - 27 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 27 Apr 2021
avatar rjharishabh
rjharishabh - comment - 27 Apr 2021

I have only changed the groups and fields view in com_fields

avatar brianteeman
brianteeman - comment - 27 Apr 2021

Yes thats right and that is used in multiple places. For example the fields in com_contact

avatar rjharishabh
rjharishabh - comment - 27 Apr 2021

I understood
Thanks

avatar rjharishabh rjharishabh - change - 27 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-27 13:34:39
Closed_By rjharishabh
Labels Added: ?
avatar rjharishabh rjharishabh - close - 27 Apr 2021
avatar joomdonation
joomdonation - comment - 27 Apr 2021

@rjharishabh I'm not sure 100% but if you want, you can give it another try by modify this line of code:

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_fields/src/Field/FieldcontextsField.php#L60

to something like:

$contexts = $component->getContexts();

if (count($contexts) > 1)
 {
	return $contexts;
 }

That should make it behaves in the same way with Joomla 3. See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/models/fields/fieldcontexts.php#L64 for reference.

avatar rjharishabh
rjharishabh - comment - 27 Apr 2021

Thanks @joomdonation

avatar chmst
chmst - comment - 27 Apr 2021

oops - did not watch this thread and comitted #33373

Add a Comment

Login with GitHub to post a comment