I think you're going to have to change the button names "reset to default" so that it is clearer what they refer to. eg body and message

And there are now three language strings that can be removed as the fields they refer to are no longer present

First impressions are great - massive massive improvement

First impressions are great - massive massive improvement

Thanks for the feedback. Assume this PR is in right direction, I will work on further clean up and improvements.

Great - let me know when its ready for full testing

@Quy Please help committing the suggested changes yourself. Many thanks !

My last commit added a new column extension column to #__mail_templates table. The only improvement from this commit is that it allows hiding mail templates from disabled extensions from Mail Templates management screen. Do you think this is useful/needed? If not, I will revert that commit.

My last commit added a new column extension column to #__mail_templates table. The only improvement from this commit is that it allows hiding mail templates from disabled extensions from Mail Templates management screen. Do you think this is useful/needed?

I think that could be useful, but I am not the expert. @Hackwar What do you think?

Applied the PR and then the database fix
Opened the component and it said No results
Verified that the database table still exists
Tried to use the search filter and selected my one language (english) and got the following 500 error

500 Column 'extension' in IN/ALL/ANY subquery is ambiguous Column 'extension' in IN/ALL/ANY subquery is ambiguous

@brianteeman Thanks for testing. It was too late for me last night and I did not test my last commit carefully enough. I planned to do final test myself today before pinging you for testing but you were too fast :).

Back to the issue:

1. The no results error, I guess it is because one SQL command is not executed when you use database fix. Please run the SQL commands below to your database then try again, it should solve the issue (of course #__ should be replaced with table prefix used for your site)

UPDATE `#__mail_templates` SET `extension` = SUBSTRING(`template_id`, 1, POSITION('.' IN `template_id`) - 1);

2. The error 500 when select a language is a bug. I fixed it. Please re-apply the patch and test it again. Thanks.

It was late for me too or I would have spotted the problem as the query was not structural. ;)

The Reset buttons don't appear to do anything

I guess break-word is the wrong class

Other than those small things this is much more usable - thank you very much - you're a superstar

@brianteeman Thanks for testing and giving feedback

1. For break-word class, it was inherited from original code. I remove the class for now
2. For reset buttons, I can only guess that happens because the change to js file is not applied yet? I'm not sure how you applied the patch, maybe you need to run npm ? I usually test it by download and install update for these kind of PRs.

Maybe you can get this zip file, unzip it media folder on your Joomla installation and try again? It contains the complied js files for this PR which I get from update package

com_mails.zip

Sorry I forgot to run npm when i switched branches. The reset buttons work as intended

Sorry I forgot to run npm when i switched branches. The reset buttons work as intended

Great. Thanks for confirming.

I have tested this item ✅ successfully on e9cbb43

I have tested this item ✅ successfully on e9cbb43

RTC

Thanks everyone !