User tests: Successful: Unsuccessful:
Title |
|
I can't split my commits into different Pull Requests. They automaticly added to this Pull Request.
You would need to create separate Pull Requests, each one originating from a different branch of your fork of the CMS. That way, you can easily update each PR individually just by working in that branch.
I tried, but it only compare my branch with your branch and add all commits.
Sry - but i can't select seperate commits.
When this still is not working - i must stop contributing, because it's a waste of my time to make things multiple.
Title |
|
That is correct, you can't select separate commits. Github pull requests are based on branches, so you need to apply the commits to different branches for separate pull requests.
When i make a new branch (https://github.com/shopfe/joomla-cms/tree/codestyle/user)
an then click on "Compare & Pull request" it still shows 8 files.
But i commited only 3 Files. (5 other files are commited in my forked staging)
I need to fork and directly start to branch - but this means, to start again.
Is it not possible to use this Pull Request?
sorry for wasting your time - but its my first time that i contribute a big project. In other problems - there isn't such a problem.
I think I understand the issue. The branch that you are using as the basis for the others (https://github.com/shopfe/joomla-cms/tree/codestyle/user) already has those commits and thus all new branche based on it will show those changes. If you use https://github.com/shopfe/joomla-cms/tree/3.3-dev as the basis for the new branches, it should be clean and not show any changes when you click "Compare & Pull request". You can then use $ git cherry-pick
(http://nathanhoad.net/how-to-cherry-pick-changes-with-git) to apply specific commits to the new branches.
sorry for wasting your time - but its my first time that i contribute a big project. In other problems - there isn't such a problem.
It's not a problem or waste of time. We appreciate your contributions. If you have any suggestions on how to make it easier, we'd appreciate hearing them.
Okay - i will try it again
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-18 20:48:47 |
Thank you!
I can't use 3.3-dev - there are many commits that are not commited . i will start again ...
I can't use 3.3-dev - there are many commits that are not commited . i will start again ...
When you use 3.3-dev as the starting repo, you can make the resulting PR against that branch instead of the default "staging" branch. You can change the target branch when creating the PR. That probably solves the issue you see (if I'm right).
i refork again and begin with fresh branches from staging - i hope it will work now
it should work now
Looks good from what I can tell from mobile. Thanks! I'll try to review
more in detail tomorrow.
Best,
Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain
Sent from mobile. Please pardon any typos or brevity.
On Mar 18, 2014 5:20 PM, "shopfe" notifications@github.com wrote:
it should work now
—
Reply to this email directly or view it on GitHub#3321 (comment)
.
thx you.
i will send you more contributes. but first i need to have a look deeper in the joomla package.
kind regards
sebastian
Am 20.03.2014 um 18:53 schrieb Matt Thomas notifications@github.com:
Hi @shopfe I just saw that most of your commits have been merged and wanted to thank you again for your contributions! Hope to see you around here often.
—
Reply to this email directly or view it on GitHub.
I can't split my commits into different Pull Requests. They automaticly added to this Pull Request.