? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
18 Mar 2014

Tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33478&start=0

To test feed validation, enable Unicode Aliases in Global Configuration, create a menu item linking to a content category. Aliases should contain non-ASCII characters for both the menu and articles. Using simple accented letters will be enough.

Display the feed obtained and check the source (unicode characters should display percentencoded), try Validating.

This PR is a first shot at it.

avatar infograf768 infograf768 - open - 18 Mar 2014
avatar infograf768
infograf768 - comment - 21 Mar 2014

Would you better like to use
if ($data->link = JFilterOutput::stringURLSafe($data->link))
instead of
if (mb_check_encoding($data->link, 'ASCII'))

avatar wilsonge
wilsonge - comment - 21 Mar 2014

I think that would make more sense :)

avatar infograf768
infograf768 - comment - 21 Mar 2014

Changed, please test again

avatar Bakual
Bakual - comment - 21 Mar 2014

Hmm...
if ($data->link = JFilterOutput::stringURLSafe($data->link))
will always be true since it's an assignment. I think you want to compare the strings like this:
if ($data->link == JFilterOutput::stringURLSafe($data->link))

avatar wilsonge
wilsonge - comment - 21 Mar 2014

I just went with forcing the issue :P infograf768#7

avatar infograf768
infograf768 - comment - 21 Mar 2014

hmm, does not work
Moving back to previous code

avatar infograf768
infograf768 - comment - 21 Mar 2014

@wilsonge
I have another solution with a regex,
Please test again

avatar Bakual
Bakual - comment - 21 Mar 2014

Latest patch seems to work. Validator validates.

avatar bwmarkle
bwmarkle - comment - 21 Mar 2014

When "All is well — The Travis CI build passed" is listed, do we need additional testing?

My last test was with 3331, and the below is with 3320:

WITHOUT PATCH 3320

With SEF enabled, URLs like the below cause RSS to fail:

  • index.php/article-category-list/73-look-i-have-à-in-the-title

With SEF disabled, URLs don't include the alias, and RSS passes:

  • index.php?option=com_content&view=article&id=73&catid=19&Itemid=260

WITH PATCH 3320

  • Everything looks good to go
avatar Bakual
Bakual - comment - 21 Mar 2014

When "All is well — The Travis CI build passed" is listed, do we need additional testing?

Travis only checks if the unit tests pass. And there aren't unit tests for everything. Even if we have full coverage, there could still be errors which go in undetected by Travis.
So yes, manual testing is still needed and probably always will be needed.

avatar infograf768 infograf768 - close - 22 Mar 2014
avatar infograf768 infograf768 - change - 22 Mar 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-03-22 07:10:23
avatar infograf768 infograf768 - close - 22 Mar 2014
avatar puneet0191 puneet0191 - reference | 08456ae - 30 Mar 14
avatar Bakual Bakual - reference | 18693fb - 12 May 14
avatar infograf768 infograf768 - head_ref_deleted - 12 Aug 2014

Add a Comment

Login with GitHub to post a comment