Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33208] - [4.3] Moving menu lookup for tags from Router helper to actual router

? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
20 Apr 2021

Summary of Changes

This moves the menu lookup for tags from the router helper to the actual router. This improves the tag routing a little bit, especially allowing for menu items with more than one tag. However lookup of multi-level tags still doesn't work and would require something like the CategoryNode class for tags, which we don't have and wont have for 4.0.

Testing Instructions

After applying this PR, the generated URLs shouldn't have changed.

avatar Hackwar Hackwar - open - 20 Apr 2021
avatar Hackwar Hackwar - change - 20 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2021
Category ⇒ com_tags Front End
avatar richard67
richard67 - comment - 20 Apr 2021

Failing unit tests in drone and appveyor are not related to this PR but to the 4.0-dev branch at the time when this PR was created based on it. It will be fixed in the 40-dev branch with #33207 and if that is merged, this PR should be updated to that so we can see if unit tests pass here.

avatar joomdonation joomdonation - test_item - 25 Apr 2021 - Tested unsuccessfully
avatar joomdonation
joomdonation - comment - 25 Apr 2021

I have tested this item 🔴 unsuccessfully on cb9b760

I tested this using sample blog data. Link to a tag has this format http://localhost/joomla4/index.php/component/tags/millions?Itemid=101 and it causes the error (something like NomenuRules which you fixed sometime ago)

I wonder why we could not use same Router structure with other extensions?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33208.

avatar Hackwar
Hackwar - comment - 25 Apr 2021

The problem is, that the tags don't use simple IDs, but also arrays of IDs. There is actually a chunk of issues here, but unfortunately out of scope for 4.0.

avatar joomdonation
joomdonation - comment - 25 Apr 2021

@Hackwar So what we can do with this PR ? Close it now and re-visit it later? Or leave it open and you will find a solution for this later?

avatar Hackwar
Hackwar - comment - 25 Apr 2021

I'll have another look at this. If it is not merged into J4, we will have to look if we can do this in a b/c way in 4.1 or similar.

avatar Hackwar Hackwar - change - 25 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Category com_tags Front End ⇒ Administration com_admin SQL Postgresql com_banners com_contact com_content com_fields com_finder
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Category Administration com_admin SQL Postgresql com_banners com_contact com_content com_fields com_finder ⇒ com_tags Front End
avatar Hackwar Hackwar - change - 10 Aug 2021
Title
…
[4.0] Moving menu lookup for tags from Router helper to actual router
[4.1] Moving menu lookup for tags from Router helper to actual router
avatar Hackwar Hackwar - edited - 10 Aug 2021
avatar Hackwar Hackwar - change - 10 Aug 2021
Labels Added: ? ?
Removed: ?
avatar joomdonation
joomdonation - comment - 26 Aug 2021

I just tested it quickly to see if it solves the issue #35382 but it is still not working yet.

avatar DonPedro34
DonPedro34 - comment - 19 Sep 2021

Any hope that this will be fixed soon?
https://issues.joomla.org/tracker/joomla-cms/35382

avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar Hackwar Hackwar - change - 6 Jul 2022
Title
…
[4.1] Moving menu lookup for tags from Router helper to actual router
[4.2] Moving menu lookup for tags from Router helper to actual router
avatar Hackwar Hackwar - edited - 6 Jul 2022
avatar Hackwar Hackwar - change - 30 Aug 2022
Title
…
[4.2] Moving menu lookup for tags from Router helper to actual router
[4.3] Moving menu lookup for tags from Router helper to actual router
avatar Hackwar Hackwar - edited - 30 Aug 2022
avatar Hackwar Hackwar - change - 21 Oct 2022
Labels Added: ? PR-4.3-dev
Removed: ? ?
avatar Hackwar Hackwar - change - 21 Oct 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-10-21 09:25:59
Closed_By ⇒ Hackwar
avatar Hackwar Hackwar - close - 21 Oct 2022
avatar Hackwar
Hackwar - comment - 21 Oct 2022

This isn't going anywhere. I'm closing this one and will maybe start over sometime soon... or something like that...

Add a Comment

Login with GitHub to post a comment