NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
10 Apr 2021

Summary of Changes

With BS5, .form-text sets color and font-size. Thus no need to use small tag , .small, .text-muted.

Note: 2 instances related to FTP were not changed until further decision on FTP.

Testing Instructions

Code review.

or

Go to Global Configuration.
No visible changes to help description under a field.

Edit account.
No visible changes to help description above password field.

Go to System > Update > Joomla > Upload & Update
No visible changes to Maximum upload size:.

avatar Quy Quy - open - 10 Apr 2021
avatar Quy Quy - change - 10 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2021
Category Administration com_joomlaupdate JavaScript Repository NPM Change Installation Layout Front End Plugins
avatar Quy Quy - change - 10 Apr 2021
Labels Added: NPM Resource Changed ?
avatar Quy Quy - change - 10 Apr 2021
The description was changed
avatar Quy Quy - edited - 10 Apr 2021
avatar Quy Quy - change - 10 Apr 2021
The description was changed
avatar Quy Quy - edited - 10 Apr 2021
avatar dgrammatiko
dgrammatiko - comment - 10 Apr 2021

How come and the Bootstrap way of using the spans and divs is better than using the semantic element small?

avatar Quy
Quy - comment - 10 Apr 2021

I am just following Bootstrap, but if small is better then I will revert and remove .text-muted only.

avatar Quy
Quy - comment - 12 Apr 2021

Thanks for the insight. Closing for now and will redo later.

avatar Quy Quy - change - 12 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-12 16:42:31
Closed_By Quy
avatar Quy Quy - close - 12 Apr 2021

Add a Comment

Login with GitHub to post a comment