? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Apr 2021

This PR corrects the error with the id of the username field
This PR changes the labels to FTP Username and FTP Password to be consistent with other instances of ftp login details eg com_joomlaupdate and coom_config
This PR changes the name of the fields to ftp_user and ftp_password to be consistent with other instances of ftp login details eg com_joomlaupdate and coom_config

NOTE: I am unable to test if any of the ftp functionality even works (I suspect it doesnt)

avatar brianteeman brianteeman - open - 9 Apr 2021
avatar brianteeman brianteeman - change - 9 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2021
Category Administration com_installer Language & Strings
avatar joomdonation
joomdonation - comment - 10 Apr 2021

You cannot change name of the inputs like this. The reason is because the extension expects to receive data from username and password for ftp credentials (if provided)

Related code https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_installer/src/Model/InstallModel.php#L84

And https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Client/ClientHelper.php#L213

And I wonder why we allow entering ftp credentials in multiple places like this? Anyone really uses it? If FTP is really needed, isn't enable it in Global Configuration enough?

avatar joomdonation
joomdonation - comment - 10 Apr 2021

And I wonder why we allow entering ftp credentials in multiple places like this? Anyone really uses it? If FTP is really needed, isn't enable it in Global Configuration enough

Ah, maybe for security purpose because the credentials if entered in Global Configuration will be stored as plain text in configuration.php file

avatar brianteeman
brianteeman - comment - 10 Apr 2021

@joomdonation @Quy I'm not going to do anything here until we get an answer about using ftp.

avatar joomdonation
joomdonation - comment - 10 Apr 2021

Agree. We will wait for maintainer decision before doing anything further.

avatar PhilETaylor
PhilETaylor - comment - 10 Apr 2021

Loving the addition of a new RLDQ label... I wonder how effective that will be at getting decisions from the projects leadership. One could argue that decisions should not be made by a single person (the release lead) but by a project architect team, who has vision, purpose and direction for the future of the product, and not just a single release...

avatar PhilETaylor
PhilETaylor - comment - 30 Apr 2021

Following the projects decision to remove the FTP Layer from Joomla 4 - this can now be closed.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

closed

avatar brianteeman brianteeman - change - 30 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-30 10:40:57
Closed_By brianteeman
Labels Added: ? ? ?
avatar brianteeman brianteeman - close - 30 Apr 2021

Add a Comment

Login with GitHub to post a comment