[#33050] - [4.0] Contact Category list limits
- Fixed in Code Base
- 9 Apr 2021
- Medium
- Build: 4.0-dev
- # 33050
- Diff
- brianteeman:contact_list
User tests: Successful: Unsuccessful:
PR for #33021
Hopefully this resolves the bug reported with #30813.
#30904 tried to fix it by removing the feature introduced with #23710 completely which was wrong
To test
- Create at least 10 contacts in the same category
- Create a menu item to display all the contacts in that category
- in the menu options make sure that Display Select is set to show (List layouts tab)
- In the global configuration check the value for default list limit (its probably 20)
- In the front end go to the new contact list menu item
- Check that the list limit select is displayed
- Check that the value is the same as in global config
- Check that changing the value in the select works
- Go back to the admin and edit the menu item and find the # contacts to list at the bottom of the list layouts tab
- Change the value from Global to 5 and save
- Clear "cookies" !!!
- In the front end go to the updated contact list menu item
- Check that the value is the same as you just set in the menu item (eg 5)
- Check that changing the value in the select works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Language & Strings Front End |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
@joomdonation - thanks - missed that use case.
FILE: /********/src/components/com_contact/src/Model/CategoryModel.php
47 ----------------------------------------------------------------------
48 FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
49 ----------------------------------------------------------------------
50 295 | WARNING | Line exceeds 150 characters; contains 166
51 | | characters (Generic.Files.LineLength.TooLong)
52 ----------------------------------------------------------------------
I have tested this item
Note for testers: clear cookies is tricky as it forces logout - try a different browser instead?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33050.
@brianteeman Could you please fix the code style here so that I can test it and get this one merged? I see some other potential issues with the CategoryModel class (not really related to this PR), but I can make a separate PR after this one merged.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33050.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33050.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-09 16:53:12 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
Thanks for testing and merging
Thanks for making this @brianteeman!
@brianteeman Thanks for working on this issue. There are some small problems with your proposed code and I made a PR to your branch to fix it brianteeman#123 . Please review, test it and if it is OK for you, please merge it so that we can test.