Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Mar 2014

Fixes #3278

avatar Hackwar Hackwar - open - 14 Mar 2014
avatar chivitli
chivitli - comment - 14 Mar 2014

@test ok here

avatar phproberto
phproberto - comment - 14 Mar 2014

If it's going to use jQuery we should embed everything on a:

(function($) {
    // Here code that uses $
})(jQuery);

So you save all the jQuery modifications.

avatar mbabker
mbabker - comment - 14 Mar 2014

Can you make sure the compressed file gets updated too please?

On Friday, March 14, 2014, Hannes Papenberg notifications@github.com
wrote:

Fixes #3278 #3278

You can merge this Pull Request by running

git pull https://github.com/Hackwar/joomla-cms validate

Or view, comment on, or merge it at:

#3303
Commit Summary

  • Fixing validate-uncompressed.js

File Changes

Patch Links:

Reply to this email directly or view it on GitHub#3303
.

avatar Hackwar
Hackwar - comment - 27 Mar 2014

Compressed the file, but its untested. So please beware.

avatar Bakual
Bakual - comment - 28 Mar 2014

Test successful both with debug enabled and disabled. Thanks!

avatar Bakual Bakual - reference | 2ee13e5 - 28 Mar 14
avatar Bakual
Bakual - comment - 28 Mar 2014

Merged

avatar Bakual Bakual - change - 28 Mar 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-03-28 09:08:25
avatar Bakual Bakual - close - 28 Mar 2014
avatar Bakual Bakual - close - 28 Mar 2014
avatar Bakual Bakual - reference | 5080d10 - 12 May 14
avatar Hackwar Hackwar - head_ref_deleted - 10 Dec 2014

Add a Comment

Login with GitHub to post a comment