User tests: Successful: Unsuccessful:
If it's going to use jQuery we should embed everything on a:
(function($) {
// Here code that uses $
})(jQuery);
So you save all the jQuery modifications.
Can you make sure the compressed file gets updated too please?
On Friday, March 14, 2014, Hannes Papenberg notifications@github.com
wrote:
Fixes #3278 #3278
You can merge this Pull Request by running
git pull https://github.com/Hackwar/joomla-cms validate
Or view, comment on, or merge it at:
#3303
Commit Summary
- Fixing validate-uncompressed.js
File Changes
- M media/system/js/validate-uncompressed.jshttps://github.com/joomla/joomla-cms/pull/3303/files#diff-0(16)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/3303.patch
- https://github.com/joomla/joomla-cms/pull/3303.diff
Reply to this email directly or view it on GitHub#3303
.
Compressed the file, but its untested. So please beware.
Works fine.
Please comment @test on
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33443&start=0
Test successful both with debug enabled and disabled. Thanks!
Merged
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-28 09:08:25 |
@test ok here