[#3302] - Remove unnecessary reset() function call in JHtmlSelect::radiolist().
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- # 3302
- Diff
- chalet16:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Internal array pointer has not been used in JHtmlSelect::radiolist(). Therefore, the reset() call should be removed.
This PR also fixes HHVM compatibility.
got it.
You may blame the J!Tracker Application for transmitting this comment.
nicksavov
- | Labels |
Removed:
?
|
||
brianteeman
- | Status | New | ⇒ | Pending |
Could you add test instructions?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3302.
@test
Tested, radio "buttons" still work, nothing seems to break, but I am not sure this is enough testing :-P
Did not test anything related to HHVM.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3302.
@ Other testers.
For an easy test, apply patch and make sure that "radio buttons" still work. Go to Content > Article Manager > Options and "Articles" tab, make sure "Show title" can be changed and saved.
For a more time-consuming test, setup HHVM (with Vagrant) and test that without the patch the radio buttons do not work with HHVM, and with the patch they do.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3302.
| Status | Pending | ⇒ | Ready to Commit |
@test
Tested on Joomla 3.4.
Tested with patch and without patch.
The radio buttons in both (with patch & without patch) seem to work oke. No change at all.
So the patch has no effect at all!
HHVM not tested!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3302.
Moving to RTC based on testing thanks 
Also thanks to @chalet16 for coding!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3302.
| Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
mbabker
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 16:42:35 |
| Milestone |
Added: |
||
Hi,
I am new to Joomla Community.
I want to solve this bug, but not able to generate it.
Can somebody tell, how to generate this bug ?
You may blame the J!Tracker Application for transmitting this comment.