? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar PhilETaylor
PhilETaylor
4 Apr 2021

Summary of Changes

When installing from url, the input field allows autocomplete, and browsers then store this for use later.

This has lead to urls being stored in the browser, and extra_query values also being stored

As the chances of having to install the same url to the same site multiple times is very very low, there is no reason for the browser to be storing the URL values for future use, and there's no point in autofill on this field.

Also another bug, is if your autofill cache has a longer url of the same one you are trying to install (for example the same url with an appended extra_query) then after pasting in your URL (without extra_query), the browser sometimes auto-appends with the extra_query on blur, or just before blur, just when you are clicking the button, at the worst time!

Most browsers the autofill cache is PER SITE, so you lose nothing by disabling this.

Testing Instructions

Apply PR, check the field doesn't present any autofill suggestions.

Actual result BEFORE applying this Pull Request

Screen Recording 2021-04-04 at 01 30 56 pm

Screen Recording 2021-04-04 at 01 24 29 pm

Expected result AFTER applying this Pull Request

Browser doesn't store, or present a saved listed of urls for autocompletion.

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 4 Apr 2021
avatar PhilETaylor PhilETaylor - change - 4 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2021
Category Front End Plugins
avatar PhilETaylor PhilETaylor - change - 4 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 4 Apr 2021
avatar PhilETaylor PhilETaylor - change - 4 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 4 Apr 2021
avatar brianteeman
brianteeman - comment - 4 Apr 2021

Please dont. I use this ability everyday several times to install patchtester

avatar PhilETaylor
PhilETaylor - comment - 4 Apr 2021

Install a text snippets expander :) then you can just map a few chars to the url and then just type a few chars like "ipttt" and have that expand to the url. or even use Mac keyboard shortcuts

Screenshot 2021-04-04 at 14 19 11

avatar brianteeman
brianteeman - comment - 4 Apr 2021

No thanks I would rather use the native functionality of a url field - and I dont use a mac ;)

PS lol how you have a correction for Lela's name

avatar PhilETaylor
PhilETaylor - comment - 4 Apr 2021

Because Lela is always auto corrected to Lea on iPhone (Mac syncs these to iPhone)

avatar PhilETaylor
PhilETaylor - comment - 4 Apr 2021

I only use Macs BECAUSE OF YOU! Else I would still be on Ubuntu.

avatar PhilETaylor PhilETaylor - change - 18 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-18 18:27:39
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 18 Apr 2021

Add a Comment

Login with GitHub to post a comment