? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar PhilETaylor
PhilETaylor
4 Apr 2021

Pull Request for Issue #32961

Summary of Changes

When purging your cache, we need to clear the PHP Opcache of these files you are deleting.

Testing Instructions

THIS PR RELIES ON THE NEW METHODS IN #32915 and so you first need to apply that PR, or wait until its merged before testing this.

Set up your PHP to aggressively use the PHP Opcache and never use the files on the disk after compiling. Instructions for that are in #32915 (comment)

Turn on Joomla Global Configuration Caching to file system. Generate a load of cache. Purge your cache in the cache manner in admin.

Actual result BEFORE applying this Pull Request

Files are removed from the hard disk, but not from the PHP OPcache

Expected result AFTER applying this Pull Request

Files are removed from the hard disk, and expired in the PHP OPcache

Documentation Changes Required

None.

avatar PhilETaylor PhilETaylor - open - 4 Apr 2021
avatar PhilETaylor PhilETaylor - change - 4 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2021
Category Libraries
avatar PhilETaylor PhilETaylor - change - 4 Apr 2021
Title
[4] Invalidate opcache on cache file deletion without using Filesystem API forperformance reasons
[4] Invalidate opcache on cache file deletion without using Filesystem API for 'performance reasons'
avatar PhilETaylor PhilETaylor - edited - 4 Apr 2021
avatar richard67 richard67 - change - 6 Apr 2021
Labels Added: ?
7054dcd 6 Apr 2021 avatar richard67 CS
avatar richard67
richard67 - comment - 6 Apr 2021

@PhilETaylor I was able to commit Quy's suggested CS change here on GitHub.

avatar PhilETaylor
PhilETaylor - comment - 6 Apr 2021

Thanks - I think it was the GitHub iPhone App just being silly. I have reported it this morning to their developers.

avatar PhilETaylor
PhilETaylor - comment - 6 Apr 2021

Merged into #32915

avatar PhilETaylor PhilETaylor - close - 6 Apr 2021
avatar PhilETaylor PhilETaylor - change - 6 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-06 16:54:26
Closed_By PhilETaylor

Add a Comment

Login with GitHub to post a comment