? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar jagatheeswar
jagatheeswar
3 Apr 2021

Pull Request for Issue # .

Summary of Changes

added a single word.

Testing Instructions

no need to test.

Actual result BEFORE applying this Pull Request

Ready to install Joomla?

Expected result AFTER applying this Pull Request

Are u ready to install Joomla?

Documentation Changes Required

avatar jagatheeswar jagatheeswar - open - 3 Apr 2021
avatar jagatheeswar jagatheeswar - change - 3 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2021
Category Repository Administration com_admin SQL
avatar jagatheeswar jagatheeswar - change - 3 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-03 14:57:29
Closed_By jagatheeswar
Labels Added: ?
avatar jagatheeswar jagatheeswar - close - 3 Apr 2021
avatar jagatheeswar jagatheeswar - change - 3 Apr 2021
Status Closed New
Closed_Date 2021-04-03 14:57:29
Closed_By jagatheeswar
avatar jagatheeswar jagatheeswar - change - 3 Apr 2021
Status New Pending
avatar jagatheeswar jagatheeswar - reopen - 3 Apr 2021
avatar brianteeman
brianteeman - comment - 3 Apr 2021

I am sure that you didnt intend to change 106 files

avatar jagatheeswar
jagatheeswar - comment - 3 Apr 2021

I am sure that you didnt intend to change 106 files

yes sir. but i dont know how it changed can u highlight my mistake please.

avatar brianteeman
brianteeman - comment - 3 Apr 2021

From what I can see you are attempting to change the readme.md file for joomla 4. To do this you must first be on the joomla 4 branch.

Secondly it looks as if the change you want to make is

Are u Ready to install Joomla?

Not only is this a pointless change it is not correct as "u" is not a real word

Thirdly if you look even closer you will see that there is a text only version of the readme file as well and any changes should be made in both files

avatar jagatheeswar
jagatheeswar - comment - 3 Apr 2021

From what I can see you are attempting to change the readme.md file for joomla 4. To do this you must first be on the joomla 4 branch.

Secondly it looks as if the change you want to make is

Are u Ready to install Joomla?

Not only is this a pointless change it is not correct as "u" is not a real word

Thirdly if you look even closer you will see that there is a text only version of the readme file as well and any changes should be made in both files

ok sir. I will try another time, sir. i wish to participate in GSOC but all I have is average skills learnt on my own. i did this pull request just for a practice. i will correct those as I progress. thanks for your feedback sir.

avatar Quy Quy - change - 3 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-03 15:54:30
Closed_By Quy
avatar Quy Quy - close - 3 Apr 2021

Add a Comment

Login with GitHub to post a comment