? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar jagatheeswar
jagatheeswar
3 Apr 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar jagatheeswar jagatheeswar - open - 3 Apr 2021
avatar jagatheeswar jagatheeswar - change - 3 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2021
Category Repository
avatar PhilETaylor
PhilETaylor - comment - 3 Apr 2021

This looks like #hacktoberfest spam and its not even october haha

avatar brianteeman
brianteeman - comment - 3 Apr 2021

Gsoc spam

avatar jagatheeswar
jagatheeswar - comment - 3 Apr 2021

This looks like #hacktoberfest spam and its not even october haha

i am a newbee, is there any mistake in my pull request. can u say if there is any.

avatar richard67
richard67 - comment - 3 Apr 2021

i am a newbee, is there any mistake in my pull request. can u say if there is any.

@jagatheeswar Several mistakes:

  1. When you create a new pull request (PR), you will see that there are head lines like "Summary of Changes", "Testing Instructions" and so on. They are not there for nothing, they are there so that the creator of the PR can add the corresponding information below them.
    For such a small PR it would not really need other testing instructions than "Code review", but at least those it would need.
    Furthermore your PR should at least tell about why you do that change in the readme file.

  2. The change in the readme file provided by this PR is no no value. It doesn't really add new information.
    The readme is intended to give a brief overview and summary on all you need to know to get started with Joomla.
    Anything which makes that file longer needs a good reason.

  3. The GSoC projects focus on the next mayor version 4 of Joomla, which here belongs to the 4.0-dev branch, but this PR is for the current version 3, i.e. the staging branch.

Thanks you for your contribution. At least you could see how the workflow is to make a new PR. I hope you are not disappointed when I close it now.

The next one will be better ? .

It can happen also to experienced contributors like me that a PR is wrong, so all is fine.

avatar richard67 richard67 - change - 3 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-03 14:38:09
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 3 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 3 Apr 2021

This looks like #hacktoberfest spam and its not even October haha

Im sorry, I had assumed this was automated spam, and not a genuine attempt to contribute.

This repo has had a lot of "newbie" injection in the last 2 weeks, and has a long history of spam from individuals trying to get a free Hacktoberfest T-Shirt with spam PRs

https://www.theregister.com/2020/10/01/digitalocean_hacktoberfest_pull_request_spam/

My reply should have been more like Richards. Sorry.

avatar jagatheeswar
jagatheeswar - comment - 3 Apr 2021

i am a newbee, is there any mistake in my pull request. can u say if there is any.

@jagatheeswar Several mistakes:

  1. When you create a new pull request (PR), you will see that there are head lines like "Summary of Changes", "Testing Instructions" and so on. They are not there for nothing, they are there so that the creator of the PR can add the corresponding information below them.
    For such a small PR it would not really need other testing instructions than "Code review", but at least those it would need.
    Furthermore your PR should at least tell about why you do that change in the readme file.
  2. The change in the readme file provided by this PR is no no value. It doesn't really add new information.
    The readme is intended to give a brief overview and summary on all you need to know to get started with Joomla.
    Anything which makes that file longer needs a good reason.
  3. The GSoC projects focus on the next mayor version 4 of Joomla, which here belongs to the 4.0-dev branch, but this PR is for the current version 3, i.e. the staging branch.

Thanks you for your contribution. At least you could see how the workflow is to make a new PR. I hope you are not disappointed when I close it now.

The next one will be better ? .

It can happen also to experienced contributors like me that a PR is wrong, so all is fine.

thank you for your information sir. i studied git on my own and tried. i just did for a practice sir. i will correct my mistake as i learn. thanks for ur feedback sir.

Add a Comment

Login with GitHub to post a comment