? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
2 Apr 2021

Pull Request for Issue #32950.

Summary of Changes

This PR add routing support for com_config, solves the issue #32950 . I must be honest that I still don't understand all the part component architecture in Joomla 4, so some of the code in this PR is just copy and modify. Hope I don't make any mistake.

Testing Instructions

  1. See #32950 , confirm the issue
  2. Apply patch, confirm the issue fixed.
avatar joomdonation joomdonation - open - 2 Apr 2021
avatar joomdonation joomdonation - change - 2 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2021
Category Administration com_config Front End
f4ebc12 2 Apr 2021 avatar joomdonation CS
avatar joomdonation joomdonation - change - 2 Apr 2021
Labels Added: ?
bc7543a 2 Apr 2021 avatar joomdonation CS
avatar brianteeman brianteeman - test_item - 2 Apr 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 Apr 2021

I have tested this item successfully on de7beaa

Thanks very much


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32960.

avatar sandramay0905 sandramay0905 - test_item - 5 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 5 Apr 2021

I have tested this item successfully on de7beaa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32960.

avatar Quy Quy - change - 5 Apr 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32960.

avatar wilsonge wilsonge - close - 7 Apr 2021
avatar wilsonge wilsonge - merge - 7 Apr 2021
avatar wilsonge wilsonge - change - 7 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-07 00:02:16
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 7 Apr 2021

Thanks!

avatar sandewt
sandewt - comment - 7 Apr 2021

Oops, was the next code review visible to you?

Why

function (Container $container) {

and not as usual?

function (Container $container)
{
avatar joomdonation
joomdonation - comment - 7 Apr 2021

Thanks @sandewt. I made #33046 to fix this code style issue.

Add a Comment

Login with GitHub to post a comment