? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
2 Apr 2021

Pull Request for Issue #32829.

Summary of Changes

This PR fix issue #32829. category view uses different key to get form data from session, so we need to override save method in the controller to set this data using the right key.

Testing Instructions

  1. Access to Content -> Categories, create a new category
  2. Enter an existing Alias into Alias field (so that category could not be saved)
  3. Apply patch
  4. Before patch: Error message displayed, but form data lost when you are redirected back to add category screen
  5. After patch: Error message displayed, you are redirected back to add category screen but the data you entered before is kept so that you don't have to re-enter.
  6. Click on Cancel button to cancel adding the category with that same Alias, you will be redirected back to Categories List screen.
  7. Press New button to add new category again, make sure you don't see the old data from previous failed add.
avatar joomdonation joomdonation - open - 2 Apr 2021
avatar joomdonation joomdonation - change - 2 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2021
Category Administration com_categories
d9d8e03 2 Apr 2021 avatar joomdonation Typo
avatar joomdonation joomdonation - change - 2 Apr 2021
Labels Added: ?
avatar ceford ceford - test_item - 2 Apr 2021 - Tested successfully
avatar ceford
ceford - comment - 2 Apr 2021

I have tested this item successfully on d9d8e03

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar alikon alikon - test_item - 2 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 2 Apr 2021

I have tested this item successfully on d9d8e03


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar alikon alikon - change - 2 Apr 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar SharkyKZ SharkyKZ - test_item - 2 Apr 2021 - Tested unsuccessfully
avatar SharkyKZ
SharkyKZ - comment - 2 Apr 2021

I have tested this item ? unsuccessfully on d9d8e03

Data remains after cancelling a failed edit.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar Quy Quy - change - 2 Apr 2021
Status Ready to Commit Pending
avatar joomdonation joomdonation - change - 2 Apr 2021
The description was changed
avatar joomdonation joomdonation - edited - 2 Apr 2021
avatar joomdonation
joomdonation - comment - 2 Apr 2021

Thanks @SharkyKZ for reviewing the PR, didn't think about that cancel action. I updated the code and should fix your reported issue now. I also updated testing instructions to include your test case.

@ceford @alikon When you have time, please help testing it again.

avatar alikon alikon - test_item - 4 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 4 Apr 2021

I have tested this item successfully on 9815e11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar ceford ceford - test_item - 5 Apr 2021 - Tested successfully
avatar ceford
ceford - comment - 5 Apr 2021

I have tested this item successfully on 9815e11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar alikon alikon - change - 5 Apr 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32959.

avatar richard67 richard67 - close - 9 Apr 2021
avatar richard67 richard67 - merge - 9 Apr 2021
avatar richard67 richard67 - change - 9 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-09 16:59:38
Closed_By richard67
Labels Added: ?
avatar richard67
richard67 - comment - 9 Apr 2021

Thanks!

Add a Comment

Login with GitHub to post a comment