NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar rs4231199
rs4231199
31 Mar 2021

Pull Request for Issue #32916 .

Summary of Changes

Set top as 0, So that, it shows in all screen sizes.

Testing Instructions

Apply the patch.

Actual result BEFORE applying this Pull Request

Can be seen in the original issue.
Note that you might need to zoom out to see the loader.

Expected result AFTER applying this Pull Request

image

avatar rs4231199 rs4231199 - open - 31 Mar 2021
avatar rs4231199 rs4231199 - change - 31 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2021
Category JavaScript Repository NPM Change
avatar PhilETaylor PhilETaylor - test_item - 31 Mar 2021 - Tested unsuccessfully
avatar PhilETaylor
PhilETaylor - comment - 31 Mar 2021

I have tested this item ? unsuccessfully on 103e796

I tested this, although its now in the right place, (so maybe I should say this is a success?)

  • it did not animate until I blurred by hitting ESC on my keyboard. Your screenshot shows it animating...
  • Sometimes the overlay did not appear at all after pressing the button "check and install" until I blurred by pressing ESC on the keyboard
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32940.
avatar rs4231199
rs4231199 - comment - 2 Apr 2021

@PhilETaylor It works fine on Firefox on windows. Can you share your system information?

avatar infograf768
infograf768 - comment - 2 Apr 2021

This does not work, either with Macintosh safari or firefox or chrome

avatar infograf768
infograf768 - comment - 2 Apr 2021

Here is an animated gif for Firefox macintosh.

spinner

Details of spinner placement

Screen Shot 2021-04-02 at 07 52 53

Detail of what is displayed briefly when install is almost done

Screen Shot 2021-04-02 at 07 53 21

EDIT: corrected test below

avatar PhilETaylor
PhilETaylor - comment - 2 Apr 2021

@PhilETaylor It works fine on Firefox on windows. Can you share your system information?

My primary testing is normally with with Safari on macOS.

avatar infograf768
infograf768 - comment - 2 Apr 2021

I correct my test.

I had some issues with npm ci.
The patch is OK for Firefox and Chrome Macintosh.

Indeed I have an issue with Safari where the spinner does not animate.

avatar infograf768
infograf768 - comment - 2 Apr 2021

@PhilETaylor
I also have an issue with WebInstaller and Safari-Macintosh (while no such issue with Chrome or Firefox.)

Screen Shot 2021-04-02 at 12 06 30

avatar PhilETaylor
PhilETaylor - comment - 2 Apr 2021

Currently working fine for me :)

Screenshot 2021-04-02 at 11 10 30

avatar sandramay0905 sandramay0905 - test_item - 5 Apr 2021 - Tested unsuccessfully
avatar sandramay0905
sandramay0905 - comment - 5 Apr 2021

I have tested this item ? unsuccessfully on 103e796

No animate on Mac-Safari, works on Mac-Firefox.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32940.

avatar dips1400 dips1400 - test_item - 9 May 2021 - Tested successfully
avatar dips1400
dips1400 - comment - 9 May 2021

I have tested this item successfully on 103e796

Works fine on chrome..!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32940.

avatar chmst chmst - change - 31 Jan 2022
Labels Added: ? NPM Resource Changed
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar laoneo
laoneo - comment - 21 Oct 2022

Is this pr already solved with the merge of #37570?

avatar Hackwar
Hackwar - comment - 21 Oct 2022

Yes, this seems to be solved with that PR, so I'm closing this one.

avatar Hackwar Hackwar - change - 21 Oct 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-10-21 14:17:44
Closed_By Hackwar
Labels Added: ?
Removed: ?
avatar Hackwar Hackwar - close - 21 Oct 2022

Add a Comment

Login with GitHub to post a comment