? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
28 Mar 2021

Pull Request for Issue #32908.

Actual result BEFORE applying this Pull Request

before voting

Expected result AFTER applying this Pull Request

vote

Documentation Changes Required

No

avatar rjharishabh rjharishabh - open - 28 Mar 2021
avatar rjharishabh rjharishabh - change - 28 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Front End Plugins
avatar rjharishabh rjharishabh - change - 28 Mar 2021
Title
css changes in voting plugin
[4.0] css changes in voting plugin
avatar rjharishabh rjharishabh - edited - 28 Mar 2021
avatar brianteeman
brianteeman - comment - 28 Mar 2021

why are you changing the height?

avatar rjharishabh
rjharishabh - comment - 29 Mar 2021

why are you changing the height?

for mobile users

avatar infograf768
infograf768 - comment - 29 Mar 2021

@rjharishabh
Have y7ou tested #31098

avatar rjharishabh
rjharishabh - comment - 29 Mar 2021

@rjharishabh
Have y7ou tested #31098

No

avatar brianteeman
brianteeman - comment - 29 Mar 2021

That was a hint that you probably should

avatar rjharishabh
rjharishabh - comment - 29 Mar 2021

That was a hint that you probably should

yeah sure, I will test

avatar rjharishabh rjharishabh - change - 29 Mar 2021
Labels Added: ?
avatar rjharishabh rjharishabh - change - 29 Mar 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 29 Mar 2021
avatar rjharishabh
rjharishabh - comment - 29 Mar 2021

please test this PR @brianteeman @infograf768

avatar rjharishabh
rjharishabh - comment - 29 Mar 2021

I have tested PR #31098

Some error occurred

avatar rjharishabh
rjharishabh - comment - 30 Mar 2021

@Quy I think it's fine now

avatar infograf768 infograf768 - test_item - 30 Mar 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 30 Mar 2021

I have tested this item successfully on 859039e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

avatar rjharishabh
rjharishabh - comment - 30 Mar 2021

@infograf768 Thnx for testing

avatar ceford
ceford - comment - 30 Mar 2021

I tested this and it works as described but it seems it will be redundant when #31098 gets merged - and it has a drop-down chevron,


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

avatar rjharishabh
rjharishabh - comment - 30 Mar 2021

I think it looks better now

avatar sandewt sandewt - test_item - 31 Mar 2021 - Tested unsuccessfully
avatar sandewt
sandewt - comment - 31 Mar 2021

I have tested this item ? unsuccessfully on efe66e7

Patch doesn't work in responsive mode


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

avatar sandewt
sandewt - comment - 31 Mar 2021

The patch doesn't work in the responsive mode: see image

screen shot 2021-03-31 at 09 50 05

You can solve this with the following code: 'style' => 'width: 120px;'
This results in:

<?php echo HTMLHelper::_('select.genericlist', $options, 'user_rating', array('class' => 'form-select form-select-sm', 'style' => 'width: 120px;'), 'value', 'text', '5', 'content_vote_' . (int) $row->id); ?>

issue-2
[EDIT]


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.
avatar sandewt sandewt - test_item - 31 Mar 2021 - Tested successfully
avatar sandewt
sandewt - comment - 31 Mar 2021

I have tested this item successfully on ee406f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

avatar rjharishabh
rjharishabh - comment - 31 Mar 2021

Thanks for testing @sandewt

avatar rjharishabh
rjharishabh - comment - 31 Mar 2021

please test this PR @infograf768 and @ceford again
there are some changes

avatar ceford ceford - test_item - 31 Mar 2021 - Tested successfully
avatar ceford
ceford - comment - 31 Mar 2021

I have tested this item successfully on ee406f1

Works in wide and narrow screen modes. But no css changes in diff and Vote is below <Prev button - a separate issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

avatar Quy Quy - change - 31 Mar 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

avatar rjharishabh
rjharishabh - comment - 1 Apr 2021

I have tested this item successfully on ee406f1

Works in wide and narrow screen modes. But no css changes in diff and Vote is below <Prev button - a separate issue.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

PR #32914

avatar infograf768
infograf768 - comment - 1 Apr 2021

imho, I prefer #31098 using svg.

avatar rjharishabh rjharishabh - change - 9 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 9 Apr 2021
avatar drmenzelit drmenzelit - close - 15 Apr 2021
avatar drmenzelit drmenzelit - merge - 15 Apr 2021
avatar drmenzelit drmenzelit - change - 15 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-15 19:14:34
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit
drmenzelit - comment - 15 Apr 2021

Thanks @rjharishabh for your first contribution!
The select field and the button are not aligned correctly, but that can be improved on another PR
grafik

Add a Comment

Login with GitHub to post a comment