User tests: Successful: Unsuccessful:
Pull Request for Issue #32908.
No
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Title |
|
why are you changing the height?
for mobile users
@rjharishabh
Have y7ou tested #31098
@rjharishabh
Have y7ou tested #31098
No
That was a hint that you probably should
That was a hint that you probably should
yeah sure, I will test
Labels |
Added:
?
|
please test this PR @brianteeman @infograf768
I have tested this item
@infograf768 Thnx for testing
I tested this and it works as described but it seems it will be redundant when #31098 gets merged - and it has a drop-down chevron,
I think it looks better now
I have tested this item
Patch doesn't work in responsive mode
The patch doesn't work in the responsive mode: see image
You can solve this with the following code: 'style' => 'width: 120px;'
This results in:
<?php echo HTMLHelper::_('select.genericlist', $options, 'user_rating', array('class' => 'form-select form-select-sm', 'style' => 'width: 120px;'), 'value', 'text', '5', 'content_vote_' . (int) $row->id); ?>
I have tested this item
please test this PR @infograf768 and @ceford again
there are some changes
I have tested this item
Works in wide and narrow screen modes. But no css changes in diff and Vote is below <Prev button - a separate issue.
Status | Pending | ⇒ | Ready to Commit |
RTC
I have tested this item
✅ successfully on ee406f1Works in wide and narrow screen modes. But no css changes in diff and Vote is below <Prev button - a separate issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.
PR #32914
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-15 19:14:34 |
Closed_By | ⇒ | drmenzelit | |
Labels |
Added:
?
|
Thanks @rjharishabh for your first contribution!
The select field and the button are not aligned correctly, but that can be improved on another PR
why are you changing the height?