[#32918] - [3] Ensure opcache file invalidate on file copy & delete
- Closed
- 27 Apr 2021
- Medium
- Build: staging
- # 32918
- Diff
- PhilETaylor:opcacheonwrite3
User tests: Successful: Unsuccessful:
This is part 2 of #32592 and directed at Joomla 3
Summary of Changes
When PHP is configured to use modern Opcache, PHP will attempt to hold the compiled version cached in memory.
There are many ways to configure opcache invalidations, including never revisiting the source PHP to compile it again ever (if opcache.validate_timestamps is disabled for example)
To fully ensure that files that Joomla writes to the hard disk are taken into account by a server with a correct configured (or badly configured) opcache, we need to invalidate files from the opcache after writing a new version to the disk.
Joomla has previously used opcache_reset to do this, but its clear this is not good enough.
Testing Instructions
Hard to test unless you really know what you are doing and can reconfigure all your PHP stack to include opcaching. Also some of the edge cases this fixes will only become clear if you are an extension developer mass distributing extensions.
Install some extensions - nothing should break.
Actual result BEFORE applying this Pull Request
You can install extensions
Expected result AFTER applying this Pull Request
You can install extensions and opcache for each file is invalidated
Documentation Changes Required
none
// cc @nikosdion
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
@PhilETaylor Did his thumb down come before or after the isset check was added? If before, then it maybe was that.
It's just one of many PRs like that ... I'm not the only one complaining about it either, he has been doing it everywhere - it's so unhelpful
| Closed_By | SharkyKZ | ⇒ | joomla-cms-bot |
SharkyKZ
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-01 15:29:31 |
| Closed_By | ⇒ | SharkyKZ |
Set to "closed" on behalf of @SharkyKZ by The JTracker Application at issues.joomla.org/joomla-cms/32918
bembelimen
- | Status | Closed | ⇒ | New |
| Closed_Date | 2021-04-01 15:29:31 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
| Status | New | ⇒ | Pending |
method updated here now too
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-27 16:42:20 |
| Closed_By | ⇒ | PhilETaylor |
Abandoning this for Joomla 3.
The Joomla 4 version of this has received much more attention, refinement and testing and comment and fine tuning.
Joomla announced that Joomla 3.9.24 was the last version of Joomla 3 to be released (despite 3.9.25 and 3.9.26 already here, and a milestone for 3.9.27 already starting to gather issues), there is no point fixing this in Joomla 3 - but lets get it right for Joomla 4.
@PhilETaylor Unit tests failing:
See https://ci.appveyor.com/project/release-joomla/joomla-cms/builds/38443204/job/es3oo3tjn6285q8v?fullLog=true .