@PhilETaylor please test this PR

I have tested this item ✅ successfully on 0e1f307

much better - thanks

@PhilETaylor Thnx for testing

@SharkyKZ can i ask you please why you sometimes give a "thumps-down" without a comment? i'm interested about reasons for thumps-down but without a word its for me a strange behaviour.

@SharkyKZ can i ask you please why you sometimes give a "thumps-down" without a comment? i'm interested about reasons for thumps-down but without a word its for me a strange behaviour.

same question @SharkyKZ

He does it a lot, and never answers why :-(

Please test this PR @ceford

I have tested this item ✅ successfully on 0e1f307

I had to enable the Vote plugin and position it below - then the PR works as described and it is clearly more logical for Vote to appear above Next/Previous than below.

Thnx for testing

RTC

I assume by moving it that it is no longer afterDisplayContent.

I assume by moving it that it is no longer afterDisplayContent.

I think it's related to voting

@Quy
is there anything that I have to change

There is a reason @SharkyKZ thumbed down... Just add an image in the article and look at the stars placement.

Before patch

After patch

There is a reason @SharkyKZ thumbed down...

Trust me there was not... he just went to all my PR's and did it. its obviously personal. He did it to a load of other PRs within seconds too.

Just add an image in the article and look at the stars placement.

This is unrelated.All the PR did was move the stars from after the pagination (which is completely the wrong place for it) to above the pagination. If then the css needs tweaking at a template level it should be.

CSS needs tweaking for the size of the vote select too.

Trust me there was not... he just went to all my PR's and did it. its obviously personal. He did it to a load of other PRs within seconds too.

I don't think so. I don't know why he is not happy with Joomla! now but from what I see, most of the time, @SharkyKZ is usually right with his thumb down.

Well if he cannot be bothered to give feedback then I'll just ignore the thumbs down. They are totally unhelpful.

If I get his thumb down for my PR, I would look at my code again to see if I could make any mistake :D.

He should be given some feedback on how to improve

All the PR did was move the stars from after the pagination (which is completely the wrong place for it) to above the pagination. If then the css needs tweaking at a template level it should be.

So be it, but in the same PR. It may also need to insert the code into a div.

No worries - Im not invested in this, I just reported it as a bug, which it clearly was. Im trying to work on the bigger issues this week ;)

@PhilETaylor @infograf768
no problem, I am working on it, I have some other stuff to complete then I will look into this later

@infograf768 @Quy
please test

It's looking better now.

I have tested this item ✅ successfully on 9c699ae

This needs some margin/padding when no images, displayed in blog and placed at bottom.

@infograf768 i had made an issue #33164

when I am testing the output is this

@rjharishabh you have to look at the blog-menu, not the article-view.

when I am testing the output is this

Are you using the latest version of J4? In the last few days several changes have been merged to the vote plugin !

when I am testing the output is this

Are you using the latest version of J4? In the last few days, several changes have been merged to the vote plugin!

This branch is not updated.
How can I update this branch with the latest changes? Please help @sandewt

How can I update this branch with the latest changes? Please help @sandewt

See: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment

• Install: composer, node.js and git

In Windows, I use the cmd prompt to clone the latest Joomla 4 version.

git clone https://github.com/joomla/joomla-cms.git -b 4.0-dev /xampp/htdocs/bugtesting/joomla

I would like to hear if it could be simpler !?

the 4.0-dev branch is updated with new changes
but the PR branch pagination is not updated
So how can I pagination branch with the new changes?

I don't think this PR is correct: changing the position of afterDisplayContent has effects on all plugins using this event. For me the "pagination" = navigation between articles is part of the content, so afterDisplayContent should be below the pagination.

I don't think this PR is correct: changing the position of afterDisplayContent has effects on all plugins using this event. For me the "pagination" = navigation between articles is part of the content, so afterDisplayContent should be below the pagination.

Correct. Changing it here will change every plugin using afterDisplayContent

The implementation in this PR of the fix for #32909 may be incorrect, but Im sure we can all agree that the voting should be before the pagination and not after it like it is currently as per the screenshots here #32909

the voting should be before the pagination

agree

The implementation in this PR of the fix for #32909 may be incorrect, but Im sure we can all agree that the voting should be before the pagination and not after it like it is currently as per the screenshots here #32909

I agree with that, but we have to find another way than moving the afterDisplayContent

The implementation in this PR of the fix for #32909 may be incorrect, but Im sure we can all agree that the voting should be before the pagination and not after it like it is currently as per the screenshots here #32909

I agree with that, but we have to find another way than moving the afterDisplayContent

Yes, I agree

Has anyone looked at joomla 3 and worked out how it's done there?

Has anyone looked at joomla 3 and worked out how it's done there?

The same issue, see image.

I don't think this PR is correct: changing the position of afterDisplayContent has effects on all plugins using this event. For me the "pagination" = navigation between articles is part of the content, so afterDisplayContent should be below the pagination.

What do you think of this minor adjustment? afterDisplayContent direct before pagination

Now

if (!empty($this->item->pagination) && $this->item->paginationposition && $this->item->paginationrelative) :
	echo $this->item->pagination;
?>
<?php endif; ?>
<?php // Content is generated by content plugin event "onContentAfterDisplay" ?>
<?php echo $this->item->event->afterDisplayContent; ?>

Proposal

<?php // Content is generated by content plugin event "onContentAfterDisplay" ?>
<?php echo $this->item->event->afterDisplayContent; ?>
<?php
if (!empty($this->item->pagination) && $this->item->paginationposition && $this->item->paginationrelative) :
	echo $this->item->pagination;
?>

@sandewt This PR is the same as your proposal.

@sandewt This PR is the same as your proposal.

Yes, but the voting (content plugin) is loaded immediately before the pagination. So, no other actions are happening in the meantime. Or am I wrong?

[EDIT] Oops, I cannot reproduce my suggestion ?

This needs some margin/padding when no images, displayed in blog and placed at bottom.

#33164 (comment)