? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
28 Mar 2021

Pull Request for Issue #32598
Replaces #32666 which was incomplete and 15 days without improvements
// cc @Megh05

Summary of Changes

Both the scrolling and frameborder are deprecated attributes, so I'd suggest removing these lines of code and also removing any associated parameters for them

Testing Instructions

Create some wrapper iframe and check the output HTML for the iframe tags

Actual result BEFORE applying this Pull Request

use of scrolling and frameborder deprecated tags, and associated params

Expected result AFTER applying this Pull Request

no use of scrolling and frameborder deprecated tags, and associated params

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 28 Mar 2021
avatar PhilETaylor PhilETaylor - change - 28 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Front End com_wrapper Modules
avatar PhilETaylor PhilETaylor - change - 28 Mar 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 28 Mar 2021
avatar PhilETaylor PhilETaylor - change - 28 Mar 2021
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 28 Mar 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 28 Mar 2021
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Front End com_wrapper Modules Front End com_wrapper Language & Strings Modules
avatar PhilETaylor PhilETaylor - change - 28 Mar 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Front End com_wrapper Modules Language & Strings Administration Language & Strings Front End com_wrapper Modules
avatar Quy Quy - test_item - 28 Mar 2021 - Tested successfully
avatar Quy
Quy - comment - 28 Mar 2021

I have tested this item successfully on e59dbdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32913.

avatar alikon alikon - test_item - 29 Mar 2021 - Tested successfully
avatar alikon
alikon - comment - 29 Mar 2021

I have tested this item successfully on e59dbdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32913.

avatar alikon alikon - change - 29 Mar 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 29 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32913.

avatar richard67 richard67 - change - 29 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-29 19:52:35
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 29 Mar 2021
avatar richard67 richard67 - merge - 29 Mar 2021
avatar richard67
richard67 - comment - 29 Mar 2021

Thanks!

Add a Comment

Login with GitHub to post a comment