User tests: Successful: Unsuccessful:
Pull Request for Issue #32788 .
tr
element part of tbody
instead of body
so that it inherits right styles.Can be seen in the original issue
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository |
Also: we do have a /templates/cassiopeia/scss/vendor/_dragula.scss
although I can't find where it is used.
I have tested this item
This fixes icon layout on dragging on other pages as well as the one initially reported.
I have tested this item
OK!
- &.table {
- display: table;
.table
can't be used here because it has been already defined and messes up the styling. Either we can remove the class or rename it. I chose to remove the .table
. Can you explain why do you suggest keeping it?
Also: we do have a
/templates/cassiopeia/scss/vendor/_dragula.scss
although I can't find where it is used.
It is used by Dragula library to add the CSS to elements while they are being dragged. They provide some default CSS, but we can override it to suit our needs.
@rs4231199
I’m not questionning your patch, just its formatting. Please look at the diff I posted. Minus means taking off the line, plus means adding it, indentation and order of stuff is corrected.
As for
Also: we do have a /templates/cassiopeia/scss/vendor/_dragula.scss although I can't find where it is used.
I know what it is supposed to do, but I do not see any place in CASSIOPEA where it is used.
Labels |
Added:
NPM Resource Changed
?
|
I have tested this item
I know what it is supposed to do, but I do not see any place in CASSIOPEIA where it is used.
@infograf768 Oh. I'm sorry I misunderstood your statement. I couldn't find any use of it in CASSIOPEIA either.
I have tested this item
We can delete the cassiopea specific scss in another pr
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-08 14:49:07 |
Closed_By | ⇒ | Fedik | |
Labels |
Added:
?
|
Thanks, good job!
Drone is not happy.
Would'nt it rather be something like