Feeling Lucky
?
?
[#32877] - [4.0] Remove .bg-white
- Fixed in Code Base
- 27 Mar 2021
- Medium
- Build: 4.0-dev
- # 32877
- Diff
- Quy:remove-bg-white
User tests: Successful: Unsuccessful:
Summary of Changes
The background color is already white. No need to add .bg-white which affects dark themes.
For the subhead, it has the white background, thus, no need to add .bg-white.
Testing Instructions
Code review.
or
- Install a dark theme: https://github.com/C-Lodder/joomla4-backend-template
Add/Edit an article.
- Run
npm run build:js
Switch to Atum.
Scroll up to display the subhead in Atum as before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
brianteeman
- comment
- 26 Mar 2021
You should also look at other uses of bg-white and review if they are needed
Quy
- comment
- 26 Mar 2021
@brianteeman This is the only instance.
brianteeman
- comment
- 26 Mar 2021
build\media_source\templates\atum\js\template.es6.js
| Labels |
Added:
?
|
||
| Category | Administration com_content | ⇒ | Administration com_content JavaScript Repository NPM Change |
Quy
- comment
- 26 Mar 2021
Thanks. Please retest.
brianteeman
- comment
- 26 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.
sksuryan
- comment
- 26 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 26 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-27 00:58:46 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
chmst
- comment
- 27 Mar 2021
Thanks!
I have tested this item✅ successfully on 5abcc46
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.