NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
25 Mar 2021

Pull Request for Issue #30880 #29152.

Summary of Changes

Fixes hidden notification on multiple file uploads

Testing Instructions

As in the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

a54d4a8 25 Mar 2021 avatar dgrammatiko fix
avatar dgrammatiko dgrammatiko - open - 25 Mar 2021
avatar dgrammatiko dgrammatiko - change - 25 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2021
Category JavaScript Administration com_media NPM Change Repository
avatar dgrammatiko dgrammatiko - change - 25 Mar 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 25 Mar 2021
avatar dgrammatiko dgrammatiko - change - 25 Mar 2021
Labels Added: NPM Resource Changed ?
763854e 25 Mar 2021 avatar dgrammatiko CS
avatar Quy Quy - test_item - 25 Mar 2021 - Tested successfully
avatar Quy
Quy - comment - 25 Mar 2021

I have tested this item successfully on 763854e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32868.

avatar saumyasarkar11 saumyasarkar11 - test_item - 26 Mar 2021 - Tested unsuccessfully
avatar dgrammatiko
dgrammatiko - comment - 26 Mar 2021

It fails while mass upload and mass deletion as well

That's unrelated to this PR

avatar dgrammatiko
dgrammatiko - comment - 26 Mar 2021

@saumyasarkar11 how did you tested this PR?

You need to run npm ci

avatar saumyasarkar11 saumyasarkar11 - test_item - 26 Mar 2021 - Tested successfully
avatar saumyasarkar11
saumyasarkar11 - comment - 26 Mar 2021

I have tested this item successfully on 763854e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32868.

avatar saumyasarkar11
saumyasarkar11 - comment - 26 Mar 2021

@saumyasarkar11 how did you tested this PR?

You need to run npm ci

Will keep this in mind whenever I see the "NPM Resource Changed" tag from the next time. Thank you @dgrammatiko

avatar Quy Quy - change - 26 Mar 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32868.

avatar drmenzelit drmenzelit - change - 26 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-26 13:56:00
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 26 Mar 2021
avatar drmenzelit drmenzelit - merge - 26 Mar 2021
avatar drmenzelit
drmenzelit - comment - 26 Mar 2021

Thanks

Add a Comment

Login with GitHub to post a comment