[#32851] - [4.0] Make Install from Web looking better
- Fixed in Code Base
- 25 Mar 2021
- Medium
- Build: 4.0-dev
- # 32851
- Diff
- rdeutz:webinstall
User tests: Successful: Unsuccessful:
Pull Request for Issue #19429 last bits and #30018 but changed my mind about the buttons.
Summary of Changes
- Tries to make install from web look like the other Joomla4 backend stuff
- Some javascript magic for the clean button
- Added a legend like the other tabs
Testing Instructions
- apply patch
- npm build:css
- npm build:js
- look if search works as expected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Note: Seems the language pack doesn't contain a translation for the install from web tab.
Documentation Changes Required
don't think so
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Title |
|
||||||
Note: Seems the language pack doesn't contain a translation for the install from web tab.
This string is new in j4, therefore not avalable in j3 packs
PLG_INSTALLER_WEBINSTALLER_TAB_LABEL="Install from Web"
In J3 it was
COM_INSTALLER_INSTALL_FROM_WEB="Install from Web"
Everything looks great.
Is it expected that it is not possible to select an extension to install when using the keyboard?
Is it expected that it is not possible to select an extension to install when using the keyboard?
short answer: yes
To add this we need to change the install-from-web server, because we only show the HTML. This is more or less a mistake in the design of the functionality. I looked into this but this is a huge task.
My changes here are more cosmetic and make sure it looks like the other parts of Joomla4.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32851.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-25 10:08:10 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
NPM Resource Changed
?
?
|
||
Thanks
I have tested this item✅ successfully on a82dbe8
Thank you for the work on cleaning this up. Works as expected and looks much better.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32851.