User tests: Successful: Unsuccessful:
Pull Request for Issue #32682 .
Changes done in 3 files- validate.es6.js, blocks_form.scss and bootstrap_form.scss
has-success and has-danger
is-valid and is-invalid
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Front End Templates (site) |
Labels |
Added:
NPM Resource Changed
?
|
Category | Administration Templates (admin) NPM Change JavaScript Repository Front End Templates (site) | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository |
Please add testing instructions. I makes testing possible for people who not having the ablity to read your mind or code.
Please add testing instructions. I makes testing possible for people who not having the ablity to read your mind or code.
Okay.
Thanks a lot @richard67 . When will you merge this PR? Just asking out of curiosity.
First it has to be tested with success by 2 testers who are not the author (so not you), then it will be set to status "RTC" (ready to commit), and then a maintainer will merge it sooner or later after a final review.
Okay.
@Khanjan04 The description of this PR still doesn't include testing instructions. Please add them so people know how to test your PR. Thanks in advance.
@Khanjan04 And another question: Is there an issue here on GitHub which is fixed by this PR? If so, the link to the issue should be provided in the description of this PR by adding its number after the "#" in the "Pull Request for Issue # ." at the top of this PR.
@richard67 the issue is #32682
@brianteeman Thanks ... I guess I should have seen that too here when checking the "... mentioned this pull request 4 hours ago " message above here in the history.
Go to Content > Articles.
Click New
button.
Click Save
button.
Title
and Please fill in this field
should be in red, but they are not.
This PR can't work, because it is removing the wrong scss code
@Khanjan04 can you please check again? And add the testing instructions, please.
closing, we asked three time to add testing instructions, that's enough time spend on this.
Can be reopend when all needed information are added
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-26 10:24:08 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
?
|
closing, we asked three time to add testing instructions, that's enough time spend on this.
Can be reopend when all needed information are added
Sorry I was busy with college work. I will do this as soon as possible
Hey @richard67 I have made the changes please have a look now