NPM Resource Changed ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Khanjan04
Khanjan04
24 Mar 2021

Pull Request for Issue #32682 .

Summary of Changes

Changes done in 3 files- validate.es6.js, blocks_form.scss and bootstrap_form.scss

Testing Instructions

Actual result BEFORE applying this Pull Request

has-success and has-danger

Expected result AFTER applying this Pull Request

is-valid and is-invalid

Documentation Changes Required

avatar Khanjan04 Khanjan04 - open - 24 Mar 2021
avatar Khanjan04 Khanjan04 - change - 24 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2021
Category Administration Templates (admin) NPM Change JavaScript Repository Front End Templates (site)
avatar Khanjan04 Khanjan04 - change - 24 Mar 2021
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2021
Category Administration Templates (admin) NPM Change JavaScript Repository Front End Templates (site) Administration Templates (admin) NPM Change JavaScript Repository
avatar Khanjan04
Khanjan04 - comment - 24 Mar 2021

Hey @richard67 I have made the changes please have a look now

avatar rdeutz
rdeutz - comment - 24 Mar 2021

Please add testing instructions. I makes testing possible for people who not having the ablity to read your mind or code.

avatar Khanjan04
Khanjan04 - comment - 24 Mar 2021

Please add testing instructions. I makes testing possible for people who not having the ablity to read your mind or code.

Okay.

avatar Khanjan04
Khanjan04 - comment - 24 Mar 2021

Thanks a lot @richard67 . When will you merge this PR? Just asking out of curiosity.

avatar richard67
richard67 - comment - 24 Mar 2021

First it has to be tested with success by 2 testers who are not the author (so not you), then it will be set to status "RTC" (ready to commit), and then a maintainer will merge it sooner or later after a final review.

avatar Khanjan04
Khanjan04 - comment - 24 Mar 2021

Okay.

avatar richard67
richard67 - comment - 24 Mar 2021

@Khanjan04 The description of this PR still doesn't include testing instructions. Please add them so people know how to test your PR. Thanks in advance.

avatar richard67
richard67 - comment - 24 Mar 2021

@Khanjan04 And another question: Is there an issue here on GitHub which is fixed by this PR? If so, the link to the issue should be provided in the description of this PR by adding its number after the "#" in the "Pull Request for Issue # ." at the top of this PR.

avatar brianteeman
brianteeman - comment - 24 Mar 2021

@richard67 the issue is #32682

avatar richard67 richard67 - change - 24 Mar 2021
The description was changed
avatar richard67 richard67 - edited - 24 Mar 2021
avatar richard67
richard67 - comment - 24 Mar 2021

@brianteeman Thanks ... I guess I should have seen that too here when checking the "... mentioned this pull request 4 hours ago " message above here in the history.

avatar Quy
Quy - comment - 25 Mar 2021

Go to Content > Articles.
Click New button.
Click Save button.
Title and Please fill in this field should be in red, but they are not.

avatar drmenzelit
drmenzelit - comment - 25 Mar 2021

This PR can't work, because it is removing the wrong scss code

@Khanjan04 can you please check again? And add the testing instructions, please.

avatar rdeutz
rdeutz - comment - 26 Mar 2021

closing, we asked three time to add testing instructions, that's enough time spend on this.

Can be reopend when all needed information are added

avatar rdeutz rdeutz - change - 26 Mar 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-03-26 10:24:08
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 26 Mar 2021
avatar Khanjan04
Khanjan04 - comment - 27 Mar 2021

closing, we asked three time to add testing instructions, that's enough time spend on this.

Can be reopend when all needed information are added

Sorry I was busy with college work. I will do this as soon as possible

Add a Comment

Login with GitHub to post a comment