NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
23 Mar 2021

Pull Request for Issue #32734 .

Summary of Changes

Fix the base path in js

Testing Instructions

  1. Ensure you are not logged into site administrator
  2. Login to front-end of site as super user
  3. Edit any article and click Image in the CMS Content dropdown to bring up Media Manager
  4. Select and attempt to insert any image
  • Appy patch
  • npm run build:js

Do the same steps, bonus points when you try the same in the backend.

Actual result BEFORE applying this Pull Request

Image is not inserted

Expected result AFTER applying this Pull Request

Image is inserted

Documentation Changes Required

None

avatar rdeutz rdeutz - open - 23 Mar 2021
avatar rdeutz rdeutz - change - 23 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2021
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - test_item - 23 Mar 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 23 Mar 2021

I have tested this item successfully on 2237de9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar alikon alikon - test_item - 24 Mar 2021 - Tested successfully
avatar alikon
alikon - comment - 24 Mar 2021

I have tested this item successfully on 2237de9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar alikon alikon - change - 24 Mar 2021
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 24 Mar 2021
avatar alikon
alikon - comment - 24 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar SharkyKZ SharkyKZ - test_item - 24 Mar 2021 - Tested unsuccessfully
avatar SharkyKZ
SharkyKZ - comment - 24 Mar 2021

I have tested this item ? unsuccessfully on 2237de9

Broken in backend.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar alikon alikon - change - 24 Mar 2021
Status Ready to Commit Pending
avatar alikon
alikon - comment - 24 Mar 2021

back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar infograf768
infograf768 - comment - 24 Mar 2021

Please modify

const apiBaseUrl = `${Joomla.getOptions('system.paths').rootFull}index.php?option=com_media&format=json`;

to

`const apiBaseUrl = `${Joomla.getOptions('system.paths').baseFull}index.php?option=com_media&format=json`;`
avatar rdeutz
rdeutz - comment - 24 Mar 2021

Broken in backend.

Tested this also, how do you make it fail?

avatar rdeutz
rdeutz - comment - 24 Mar 2021

@SharkyKZ got it, thanks for the test

avatar rdeutz rdeutz - change - 24 Mar 2021
Labels Added: NPM Resource Changed ?
avatar rdeutz
rdeutz - comment - 24 Mar 2021

fixed, please re-test. Sorry for not looking into it properly

avatar infograf768
infograf768 - comment - 24 Mar 2021

?

avatar infograf768 infograf768 - test_item - 24 Mar 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 24 Mar 2021

I have tested this item successfully on 1c118fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar dgrammatiko dgrammatiko - test_item - 24 Mar 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 24 Mar 2021

I have tested this item successfully on 1c118fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar infograf768 infograf768 - change - 25 Mar 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 Mar 2021

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32825.

avatar drmenzelit drmenzelit - close - 25 Mar 2021
avatar drmenzelit drmenzelit - merge - 25 Mar 2021
avatar drmenzelit drmenzelit - change - 25 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-25 08:42:50
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit
drmenzelit - comment - 25 Mar 2021

Thanks!

Add a Comment

Login with GitHub to post a comment