[#32810] - [4.0] Fix style in mobile view
- Fixed in Code Base
- 8 Apr 2021
- Medium
- Build: 4.0-dev
- # 32810
- Diff
- hitesh-coder:Mobile
User tests: Successful: Unsuccessful:
Pull Request for Issue #32797.
Steps to reproduce
System > Templates > Mail Template
Summary of Changes
changed position and size of cog icon also added padding to the following elements.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
rdeutz
- | Title |
|
||||||
I think this should be taken as two PRs
-
For the placement of the Cog - as I think a lot of people might disagree with this move as its a "designed element" of the template
-
The layout of the Mail Templates page when viewed on mobile.
@PhilETaylor but the cog icon looks a little out placed as it also overlaps in other mail template. So i think this position should be fine.
so should I remove my changes for cog-icon as someone is working on it?
We would like to see the bottom icon changed too to match size:
You can do it in this PR (changing the description appropriately) or you can create a new PR.
Visually it might be better to center the inner cog icon? Just a thought...
I am not sure what we are expecting but on my simulated iPhone 6/7/8 iOS 11 the cog is smaller but so near the top and there is no hamburger icon at all.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
The burger is at the bottom!
I thought folk would not want to see a picture of something not there. Here is the whole screen grab that I see:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
I have tested this item
OK: I now see the cog a burger icons fitting perfectly in the top an bottom bars.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
I have tested this item
Its all Perfect till width=375px, but at width=320px It is having a Space on the Top-Right in Navbar
Before:
After at width=375px
After at width=320px
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
@meinhoonharsh thanks for mentioning. I have fixed it please check.
I have tested this item
The Blank Space has been Removed at width=320px
Mobile View at width=320px
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
@meinhoonharsh and @ceford could you please test it once again. Thanks in advance.
I have tested this item
OK - also tested at 320 and 300 pixels wide - cog and burger perfectly placed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32810.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-08 08:16:07 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thank you very much for your first contribution! Well done
Please update the title with something meaningful