? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
21 Mar 2021

Pull Request for Issue #30744.

Summary of Changes

When using the suggest feature of Smart Search, it is impossible to select a suggested term by navigating to it with the keyboard. This is due to the issue that we are reacting to the onKeyUp event, which triggers a new search for suggestions whenever we press for example the arrow-down-key. The solution here is to switch to the "input" event, which fires only when the content of an input field has changed. This also has the benefit that it reacts to content which has been inserted from the clipboard via the mouse.

Testing Instructions

  1. Setup Smart Search and index content, for example by using the sample data plugins
  2. Make sure you have a menu item of type Smart Search
  3. In the search field in the frontend, start typing a term and wait for the suggestions. Keep in mind that you need at least 2 characters to get a suggestion.
  4. Press the down-key of your direction keys on the keyboad.
  5. Notice that the suggestion list flickers and doesn't select the suggested term.
  6. Apply the patch and reload the page
  7. Again type in a term and wait for the suggestions.
  8. Press the down key again and now see that an entry in the list is selected.
avatar Hackwar Hackwar - open - 21 Mar 2021
avatar Hackwar Hackwar - change - 21 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2021
Category JavaScript Repository NPM Change
avatar sakiss sakiss - test_item - 24 Mar 2021 - Tested successfully
avatar sakiss
sakiss - comment - 24 Mar 2021

I have tested this item successfully on c676d8f

I need to run npm install though to get the js file updated.
May be useful to add that in the instructions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32798.

avatar Quy Quy - test_item - 24 Mar 2021 - Tested successfully
avatar Quy
Quy - comment - 24 Mar 2021

I have tested this item successfully on c676d8f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32798.

avatar Quy Quy - change - 24 Mar 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 24 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32798.

avatar rdeutz rdeutz - change - 24 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-24 16:13:03
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 24 Mar 2021
avatar rdeutz rdeutz - merge - 24 Mar 2021

Add a Comment

Login with GitHub to post a comment