? ? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
20 Mar 2021

Pull Request for Issue # .

Summary of Changes

Added the description for a file that needs to be changed.

Testing Instructions

Code review

avatar astridx astridx - open - 20 Mar 2021
avatar astridx astridx - change - 20 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2021
Category Unit Tests Repository
avatar astridx astridx - change - 20 Mar 2021
Labels Added: ? ?
avatar astridx astridx - change - 20 Mar 2021
Labels Added: ?
Removed: ?
avatar astridx astridx - change - 21 Mar 2021
Labels Added: ?
Removed: ?
avatar astridx
astridx - comment - 21 Mar 2021

Thank you Richard. I just saw that something else was wrong.

avatar richard67 richard67 - test_item - 21 Mar 2021 - Tested successfully
avatar richard67
richard67 - comment - 21 Mar 2021

I have tested this item successfully on 55244cf

1. Code review: Ok.
2. Real test: Without a phpunit.xml, database tests fail because no database found. After proceeding as adviced in this PR, unit tests worked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32758.

avatar brianteeman brianteeman - test_item - 21 Mar 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Mar 2021

I have tested this item successfully on 55244cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32758.

avatar richard67 richard67 - change - 21 Mar 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32758.

avatar wilsonge wilsonge - change - 21 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-21 23:44:50
Closed_By wilsonge
Labels Added: ? ?
Removed: ?
avatar wilsonge wilsonge - close - 21 Mar 2021
avatar wilsonge wilsonge - merge - 21 Mar 2021
avatar wilsonge
wilsonge - comment - 21 Mar 2021

Thanks!

avatar richard67
richard67 - comment - 30 Mar 2021

@astridx @wilsonge Sorry, seems I was sleeping when reviewing this PR. I've found some issues, see #32935 . Please review.

Add a Comment

Login with GitHub to post a comment